RFC 6455 4.2.1.4 case sensitivity fix

bebo-dot-dev · bebo-dot-dev · commit c4e5f5c7e7e9 · 2016-06-04T21:31:42.000+01:00
This is a case sensitivity fix for the Connection header Upgrade value to make this part meet the requirement of IETF websocket RFC 6455 4.2.1.4: "A |Connection| header field that includes the token "Upgrade", treated as an ASCII case-insensitive value."
diff --git a/src/WebSocketsServer.cpp b/src/WebSocketsServer.cpp
@@ -590,7 +590,7 @@ void WebSocketsServer::handleHeader(WSclient_t * client, String * headerLine) {
             String headerValue = headerLine->substring(headerLine->indexOf(':') + 2);
 
             if(headerName.equalsIgnoreCase("Connection")) {
-                if(headerValue.indexOf("Upgrade") >= 0) {
+                if(headerValue.equalsIgnoreCase("Upgrade")) {
                     client->cIsUpgrade = true;
                 }
             } else if(headerName.equalsIgnoreCase("Upgrade")) {

Original file line number	Diff line number	Diff line change
`@@ -590,7 +590,7 @@ void WebSocketsServer::handleHeader(WSclient_t * client, String * headerLine) {`
`590`	`590`	`String headerValue = headerLine->substring(headerLine->indexOf(':') + 2);`
`591`	`591`
`592`	`592`	`if(headerName.equalsIgnoreCase("Connection")) {`
`593`		`- if(headerValue.indexOf("Upgrade") >= 0) {`
	`593`	`+ if(headerValue.equalsIgnoreCase("Upgrade")) {`
`594`	`594`	`client->cIsUpgrade = true;`
`595`	`595`	`}`
`596`	`596`	`} else if(headerName.equalsIgnoreCase("Upgrade")) {`