8000 Code changes for #329 · chegewara/esp32-snippets@3943f99 · GitHub
[go: up one dir, main page]

Skip to content

Commit 3943f99

Browse files
committed
Code changes for nkolban#329
Note that this is an interface breaking change.
1 parent 20214be commit 3943f99

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

cpp_utils/WebSocket.cpp

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ class WebSocketReader: public Task {
158158
case OPCODE_BINARY: {
159159
if (pWebSocketHandler != nullptr) {
160160
WebSocketInputStreambuf streambuf(pWebSocket->getSocket(), payloadLen, frame.mask==1?mask:nullptr);
161-
pWebSocketHandler->onMessage(&streambuf);
161+
pWebSocketHandler->onMessage(&streambuf, pWebSocket);
162162
//streambuf.discard();
163163
}
164164
break;
@@ -203,7 +203,8 @@ class WebSocketReader: public Task {
203203
* If no over-riding handler is provided for the "close" event, this method is called.
204204
*/
205205
void WebSocketHandler::onClose() {
206-
ESP_LOGD("WebSocketHandler", ">> WebSocketHandler:onClose()");
206+
ESP_LOGD("WebSocketHandler", ">> onClose");
207+
ESP_LOGD("WebSocketHandler", "<< onClose");
207208
} // onClose
208209

209210

@@ -217,8 +218,9 @@ void WebSocketHandler::onClose() {
217218
* ```
218219
* This will read the whole message into the string stream.
219220
*/
220-
void WebSocketHandler::onMessage(WebSocketInputStreambuf* pWebSocketInputStreambuf) {
221-
ESP_LOGD("WebSocketHandler", ">> onMessage")
221+
void WebSocketHandler::onMessage(WebSocketInputStreambuf* pWebSocketInputStreambuf, WebSocket *pWebSocket) {
222+
ESP_LOGD("WebSocketHandler", ">> onMessage");
223+
ESP_LOGD("WebSocketHandler", "<< onMessage");
222224
} // onData
223225

224226

@@ -227,7 +229,8 @@ void WebSocketHandler::onMessage(WebSocketInputStreambuf* pWebSocketInputStreamb
227229
* If no over-riding handler is provided for the "error" event, this method is called.
228230
*/
229231
void WebSocketHandler::onError(std::string error) {
230-
ESP_LOGD("WebSocketHandler", ">> WebSocketHandler:onError()");
232+
ESP_LOGD("WebSocketHandler", ">> onError: %s", error.c_str());
233+
ESP_LOGD("WebSocketHandler", "<< onError");
231234
} // onError
232235

233236

cpp_utils/WebSocket.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
#undef close
1414
#undef send
1515
class WebSocketReader;
16+
class WebSocket;
1617

1718
// +-------------------------------+
1819
// | WebSocketInputStreambuf |
@@ -45,7 +46,7 @@ class WebSocketHandler {
4546
public:
4647
virtual ~WebSocketHandler();
4748
virtual void onClose();
48-
virtual void onMessage(WebSocketInputStreambuf *pWebSocketInputStreambuf);
49+
virtual void onMessage(WebSocketInputStreambuf *pWebSocketInputStreambuf, WebSocket *pWebSocket);
4950
virtual void onError(std::string error);
5051
};
5152

0 commit comments

Comments
 (0)
0