BUG: Fix extra decref of PyArray_UInt8DType.

hawkinsp · charris · commit 2760a1305eb7 · 2024-09-30T08:58:20.000-06:00
We didn't take a reference to this type, so we shouldn't be freeing one. This appears to have been missed by PR numpy#25329.
diff --git a/numpy/_core/src/multiarray/abstractdtypes.c b/numpy/_core/src/multiarray/abstractdtypes.c
@@ -177,7 +177,6 @@ int_common_dtype(PyArray_DTypeMeta *NPY_UNUSED(cls), PyArray_DTypeMeta *other)
         /* This is a back-compat fallback to usually do the right thing... */
         PyArray_DTypeMeta *uint8_dt = &PyArray_UInt8DType;
         PyArray_DTypeMeta *res = NPY_DT_CALL_common_dtype(other, uint8_dt);
-        Py_DECREF(uint8_dt);
         if (res == NULL) {
             PyErr_Clear();
         }

Original file line number	Diff line number	Diff line change
`@@ -177,7 +177,6 @@ int_common_dtype(PyArray_DTypeMeta NPY_UNUSED(cls), PyArray_DTypeMeta other)`
`177`	`177`	`/* This is a back-compat fallback to usually do the right thing... */`
`178`	`178`	`PyArray_DTypeMeta *uint8_dt = &PyArray_UInt8DType;`
`179`	`179`	`PyArray_DTypeMeta *res = NPY_DT_CALL_common_dtype(other, uint8_dt);`
`180`		`- Py_DECREF(uint8_dt);`
`181`	`180`	`if (res == NULL) {`
`182`	`181`	`PyErr_Clear();`
`183`	`182`	`}`