8000 minor #34433 Remove wrong @group legacy annotations (nicolas-grekas) · chapa/symfony@1b2651c · GitHub
[go: up one dir, main page]
Skip to content

Commit 1b2651c

Browse files
nicolas-grekasnicolas-grekas
committed
minor symfony#34433 Remove wrong @group legacy annotations (nicolas-grekas)
This PR was merged into the 4.4 branch. Discussion ---------- Remove wrong @group legacy annotations | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - These annotations are still found on branch 5.0. Does this mean they are wrong? Why don't they make 5.0 fail if not? Commits ------- 8d84ac3 Remove wrong @group legacy annotations
2 parents 12f00e3 + 8d84ac3 commit 1b2651c

File tree

11 files changed

+2
-30
lines changed

11 files changed

+2
-30
lines changed

‎src/Symfony/Bundle/WebProfilerBundle/Tests/DependencyInjection/ConfigurationTest.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,6 @@ public function getDebugModes()
6060
}
6161

6262
/**
63-
* @group legacy
64-
*
6563
* @dataProvider getInterceptRedirectsConfiguration
6664
*/
6765
public function testConfigTreeUsingInterceptRedirects(bool $interceptRedirects, array $expectedResult)

‎src/Symfony/Bundle/WebProfilerBundle/Tests/DependencyInjection/WebProfilerExtensionTest.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,8 +142,6 @@ public function getToolbarConfig()
142142
}
143143

144144
/**
145-
* @group legacy
146-
*
147145
* @dataProvider getInterceptRedirectsToolbarConfig
148146
*/
149147
public function testToolbarConfigUsingInterceptRedirects(

‎src/Symfony/Component/HttpKernel/Tests/Bundle/BundleTest.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,6 @@ public function testGetContainerExtension()
2828
);
2929
}
3030

31-
/**
32-
* @group legacy
33-
*/
3431
public function testGetContainerExtensionWithInvalidClass()
3532
{
3633
$this->expectException('LogicException');

‎src/Symfony/Component/Routing/Loader/ObjectLoader.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ public function load($resource, $type = null)
5252
$loaderObject = $this->getObject($parts[0]);
5353

5454
if (!\is_object($loaderObject)) {
55-
throw new \LogicException(sprintf('%s:getObject() must return an object: %s returned', \get_class($this), \gettype($loaderObject)));
55+
throw new \TypeError(sprintf('%s:getObject() must return an object: %s returned', \get_class($this), \gettype($loaderObject)));
5656
}
5757

5858
if (!\is_callable([$loaderObject, $method])) {

‎src/Symfony/Component/Routing/Tests/Loader/ObjectLoaderTest.php

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,12 +62,9 @@ public function getBadResourceStrings()
6262
];
6363
}
6464

65-
/**
66-
* @group legacy
67-
*/
6865
public function testExceptionOnNoObjectReturned()
6966
{
70-
$this->expectException('LogicException');
67+
$this->expectException(\TypeError::class);
7168
$loader = new TestObjectLoader();
7269
$loader->loaderMap = ['my_service' => 'NOT_AN_OBJECT'];
7370
$loader->load('my_service::method');

‎src/Symfony/Component/Security/Core/Tests/Authentication/Provider/DaoAuthenticationProviderTest.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,6 @@
2222

2323
class DaoAuthenticationProviderTest extends TestCase
2424
{
25-
/**
26-
* @group legacy
27-
*/
2825
public function testRetrieveUserWhenProviderDoesNotReturnAnUserInterface()
2926
{
3027
$this->expectException('Symfony\Component\Security\Core\Exception\AuthenticationServiceException');

‎src/Symfony/Component/Security/Core/Tests/Authentication/Provider/UserAuthenticationProviderTest.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,6 @@ public function testAuthenticateWhenUsernameIsNotFoundAndHideIsTrue()
6262
$provider->authenticate($this->getSupportedToken());
6363
}
6464

65-
/**
66-
* @group legacy
67-
*/
6865
public function testAuthenticateWhenProviderDoesNotReturnAnUserInterface()
6966
{
7067
$this->expectException('Symfony\Component\Security\Core\Exception\AuthenticationServiceException');

‎src/Symfony/Component/Security/Http/Tests/Firewall/ExceptionListenerTest.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,6 @@ public function getAuthenticationExceptionProvider()
7272
];
7373
}
7474

75-
/**
76-
* @group legacy
77-
*/
7875
public function testExceptionWhenEntryPointReturnsBadValue()
7976
{
8077
$event = $this->createEvent(new AuthenticationException());

‎src/Symfony/Component/Security/Http/Tests/Firewall/LogoutListenerTest.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -123,9 +123,6 @@ public function testHandleMatchedPathWithoutSuccessHandlerAndCsrfValidation()
123123
$listener($event);
12412 8000 4
}
125125

126-
/**
127-
* @group legacy
128-
*/
129126
public function testSuccessHandlerReturnsNonResponse()
130127
{
131128
$this->expectException('RuntimeException');

‎src/Symfony/Component/Security/Http/Tests/RememberMe/AbstractRememberMeServicesTest.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,6 @@ public function testAutoLoginReturnsNullWhenNoCookie()
3939
$this->assertNull($service->autoLogin(new Request()));
4040
}
4141

42-
/**
43-
* @group legacy
44-
*/
4542
public function testAutoLoginThrowsExceptionWhenImplementationDoesNotReturnUserInterface()
4643
{
4744
$this->expectException('RuntimeException');

0 commit comments

Comments
 (0)
0