Merge pull request symfony#19 from Pierstoval/minor-sniffing

dunglas · web-flow · commit 2b0de570cf10 · 2018-04-16T08:05:01.000+02:00
[CS] Removed property used only in constructor
diff --git a/src/ProcessManager/WebServerManager.php b/src/ProcessManager/WebServerManager.php
@@ -23,7 +23,6 @@ final class WebServerManager
 {
     use WebServerReadinessProbeTrait;
 
-    private $documentRoot;
     private $hostname;
     private $port;
 
@@ -37,7 +36,6 @@ final class WebServerManager
      */
     public function __construct(string $documentRoot, string $hostname, int $port)
     {
-        $this->documentRoot = $documentRoot;
         $this->hostname = $hostname;
         $this->port = $port;
 
@@ -46,7 +44,7 @@ public function __construct(string $documentRoot, string $hostname, int $port)
             throw new \RuntimeException('Unable to find the PHP binary.');
         }
 
-        $this->process = new Process([$binary] + $finder->findArguments() + ['-dvariables_order=EGPCS', '-S', \sprintf('%s:%d', $this->hostname, $this->port)], $this->documentRoot, null, null, null);
+        $this->process = new Process([$binary] + $finder->findArguments() + ['-dvariables_order=EGPCS', '-S', \sprintf('%s:%d', $this->hostname, $this->port)], $documentRoot, null, null, null);
     }
 
     public function start(): void

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,6 @@ final class WebServerManager`
`23`	`23`	`{`
`24`	`24`	`use WebServerReadinessProbeTrait;`
`25`	`25`
`26`		`- private $documentRoot;`
`27`	`26`	`private $hostname;`
`28`	`27`	`private $port;`
`29`	`28`
`@@ -37,7 +36,6 @@ final class WebServerManager`
`37`	`36`	`*/`
`38`	`37`	`public function __construct(string $documentRoot, string $hostname, int $port)`
`39`	`38`	`{`
`40`		`- $this->documentRoot = $documentRoot;`
`41`	`39`	`$this->hostname = $hostname;`
`42`	`40`	`$this->port = $port;`
`43`	`41`
`@@ -46,7 +44,7 @@ public function __construct(string $documentRoot, string $hostname, int $port)`
`46`	`44`	`throw new \RuntimeException('Unable to find the PHP binary.');`
`47`	`45`	`}`
`48`	`46`
`49`		`- $this->process = new Process([$binary] + $finder->findArguments() + ['-dvariables_order=EGPCS', '-S', \sprintf('%s:%d', $this->hostname, $this->port)], $this->documentRoot, null, null, null);`
	`47`	`+ $this->process = new Process([$binary] + $finder->findArguments() + ['-dvariables_order=EGPCS', '-S', \sprintf('%s:%d', $this->hostname, $this->port)], $documentRoot, null, null, null);`
`50`	`48`	`}`
`51`	`49`
`52`	`50`	`public function start(): void`