8000 cleanup (#376) · chakra-coder/rsocket-java@bf28d69 · GitHub
[go: up one dir, main page]

Skip to content
8000

Commit bf28d69

Browse files
authored
cleanup (rsocket#376)
1 parent 3a6c990 commit bf28d69

File tree

6 files changed

+14
-5
lines changed

6 files changed

+14
-5
lines changed

rsocket-tck-drivers/src/main/java/io/rsocket/tckdrivers/common/ParseMarble.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ public ParseMarble(Subscriber<? super Payload> s, String agent) {
9595
* be sent. In other words, it allows onNext and onComplete to be sent even if we've sent all the
9696
* values we've been requested of.
9797
*
98-
* @param m
98+
* @param m marble string
9999
*/
100100
public synchronized void add(String m) {
101101
consoleUtils.info("adding " + m);
@@ -110,7 +110,7 @@ public synchronized void add(String m) {
110110
* this method unblocks the sendLatch as well as the parseLatch if we have more requests, as it
111111
* allows both emitted and non-emitted symbols to be sent,
112112
*
113-
* @param n
113+
* @param n credits to add
114114
*/
115115
public synchronized void request(long n) {
116116
numRequested += n;

rsocket-transport-aeron/src/main/java/io/rsocket/aeron/internal/EventLoop.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,8 @@ public interface EventLoop {
2323
* Executes an IntSupplier that returns a number greater than 0 if it wants the the event loop to
2424
* keep processing items, and zero its okay for the eventloop to execute an idle strategy
2525
*
26-
* @param r
26+
* @param r signal for roughly how many items could be processed.
27+
* @return whether items could be processed
2728
*/
2829
boolean execute(IntSupplier r);
2930
}

rsocket-transport-aeron/src/main/java/io/rsocket/aeron/internal/reactivestreams/AeronChannel.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,8 @@ public AeronChannel(
5656
/**
5757
* Subscribes to a stream of DirectBuffers and sends the to an Aeron Publisher
5858
*
59-
* @param in
60-
* @return
59+
* @param in the publisher of buffers.
60+
* @return Mono the completes when all publishers have been sent.
6161
*/
6262
public Mono<Void> send(Flux<? extends DirectBuffer> in) {
6363
AeronInSubscriber inSubscriber = new AeronInSubscriber(name, destination);

rsocket-transport-aeron/src/main/java/io/rsocket/aeron/internal/reactivestreams/AeronClientChannelConnector.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -303,6 +303,9 @@ private AeronClientConfig(
303303
*
304304
* @param receiveSocketAddress the address the channels receives data on
305305
* @param sendSocketAddress the address the channel sends data too
306+
* @param receiveStreamId receiving stream id
307+
* @param sendStreamId the sending stream id
308+
* @param eventLoop event loop for this client
306309
* @return new {@code AeronClientConfig}
307310
*/
308311
public static AeronClientConfig create(

rsocket-transport-aeron/src/main/java/io/rsocket/aeron/internal/reactivestreams/ReactiveStreamsRemote.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,9 @@ interface StartedServer extends Closeable {
8181
* Blocks till this server shutsdown till the passed duration.
8282
*
8383
* <p><em>This does not shutdown the server.</em>
84+
*
85+
* @param duration the number of durationUnit to wait
86+
* @param durationUnit the unit e.g. seconds
8487
*/
8588
void awaitShutdown(long duration, TimeUnit durationUnit);
8689

rsocket-transport-local/src/main/java/io/rsocket/transport/local/LocalServerTransport.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,8 @@ public static LocalServerTransport createEphemeral() {
7070

7171
/**
7272
* Remove an instance from the JVM registry.
73+
*
74+
* @param name the local transport instance to free.
7375
*/
7476
public static void dispose(String name) {
7577
registry.remove(name);

0 commit comments

Comments
 (0)
0