8000 Initial version does not work if pattern is supplied · Issue #56 · caarlos0/svu · GitHub
[go: up one dir, main page]
Skip to content

Initial version does not work if pattern is supplied #56

New issue
New issue
Open
Open
Initial version does not work if pattern is supplied#56
@jsok

Description

@jsok
jsok
opened on Jan 14, 2022

Effectively, if a pattern is supplied and no existing tags are found an error is always returned.

svu/internal/git/git.go

Lines 45 to 54 in 0b3a780

g, err := glob.Compile(pattern)
if err != nil {
return "", err
}
for _, tag := range tags {
if g.Match(tag) {
return tag, nil
}
}
return "", fmt.Errorf("no tags match '%s'", pattern)

Whereas if no pattern is supplied, it is not an error to find no tags:

svu/internal/git/git.go

Lines 38 to 40 in 0b3a780

if len(tags) == 0 {
return "", nil
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions
      0