fix tests

forozco · forozco · commit b786754fbcee · 2018-03-14T17:23:14.000-04:00
diff --git a/pyls/rpc_manager.py b/pyls/rpc_manager.py
@@ -149,9 +149,10 @@ def did_finish_callback(completed_future):
                 except JSONRPCDispatchException as e:
                     output = _make_response(request, error=e.error._data)
                 except Exception:  # pylint: disable=broad-except
-                    # TODO(forozco): add more descriptive error
                     log.exception('asynchronous method handler exception for request: %s', request)
-                    output = _make_response(request, error={'message': traceback.format_exc()})
+                    output = _make_response(request, error={
+                        'code': JSONRPCServerError.CODE, 'message': traceback.format_exc()
+                    })
                 else:
                     output = _make_response(request, result=result)
                 finally:
diff --git a/test/test_rpc_manager.py b/test/test_rpc_manager.py
@@ -53,7 +53,10 @@ def wrapper():
         rpc_manager._sent_requests.values()[0].result(timeout=1)
     message_manager.write_message.assert_called_once()
     (sent_message, ), _ = message_manager.write_message.call_args
-    assert sent_message.data == JSONRPC20Response(_id=1, error=JSONRPCServerError()._data).data
+    data = sent_message.data
+    assert data['id'] == 1
+    assert data['error']['code'] == JSONRPCServerError.CODE
+    assert 'something bad happened' in data['error']['message']
 
 
 def test_handle_request_async_error(rpc_management):
