8000 Package manager compatibility by thijse · Pull Request #24 · br3ttb/Arduino-PID-Library · GitHub
[go: up one dir, main page]

Skip to content

Package manager compatibility #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 19, 2015
Merged

Package manager compatibility #24

merged 2 commits into from
Apr 19, 2015

Conversation

thijse
Copy link
Contributor
@thijse thijse commented Apr 19, 2015

Hi,

I've added PlatformIO Library Registry manifest file, and made the library compatible with the updated (rev. 2) 1.5.x library format, so that it can be submitted for the Arduino Package Manager.

If you could you pull these changes and publish your library

to the Arduino package list
https://github.com/arduino/Arduino/wiki/Library-Manager-FAQ

and PlatformIo package list
http://docs.platformio.org/en/latest/librarymanager/creating.html#register

I could refer to these in my CmdMessenger library

ps.
Great library and awesome explanation on PID!

br3ttb added a commit that referenced this pull request Apr 19, 2015
Package manager compatibility
@br3ttb br3ttb merged commit c61fb89 into br3ttb:master Apr 19, 2015
@thijse
Copy link
Contributor Author
thijse commented Apr 19, 2015

Great, thanks!

On Sun, Apr 19, 2015 at 8:26 PM, br3ttb notifications@github.com wrote:

Merged #24 #24.


Reply to this email directly or view it on GitHub
#24 (comment).

@Lauszus
Copy link
Lauszus commented Apr 19, 2015

Note however that you still need to move all the content into the root of this repository and then create a tag. Then you need to open up an issue at the Arduino repository with a request to get it added to the Library Manager.

Please see: https://github.com/arduino/Arduino/wiki/Library-Manager-FAQ#how-can-i-add-my-library-to-library-manager.

@thijse
Copy link
Contributor Author
thijse commented Apr 20, 2015

Thanks Lauszus, I had not seen that. I personally think it is a serious limitation of the Arduino package system, having to put packages in the root of a repository. Nevertheless, Brett, are you willing to move the code, tag it and open up an issue at the Arduino repository?

@br3ttb
Copy link
Owner
br3ttb commented Apr 20, 2015

I have moved the code. it has been a LONG time since I have pushed to
github or worked in the arduino space. Can someone please give me a
confirmation that this looks like the library manager will accept it before
I go and create a tag?

On Mon, Apr 20, 2015 at 10:25 AM, Thijs Elenbaas notifications@github.com
wrote:

Thanks Lauszus, I had not seen that. I personally think it is a serious
limitation of the Arduino package system, having to put packages in the
root of a repository. Nevertheless, Brett, are you willing to move the
code, tag it and open up an issue at the Arduino repository?


Reply to this email directly or view it on GitHub
#24 (comment)
.

Brett

@Lauszus
Copy link
Lauszus commented Apr 21, 2015

@br3ttb yes it looks correct ;)

@thijse
Copy link
Contributor Author
thijse commented Apr 25, 2015

Great!

Ive submitted a request to add it to the Arduino Library Manager:

arduino/Arduino#3035

On Tue, Apr 21, 2015 at 8:50 AM, Kristian Sloth Lauszus <
notifica 80FB tions@github.com> wrote:

@br3ttb https://github.com/br3ttb yes it looks correct ;)


Reply to this email directly or view it on GitHub
#24 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0