Fix more pylint recommendations

EvaSDK · EvaSDK · commit 405d4dd82a48 · 2013-07-26T15:51:05.000+02:00
diff --git a/fluent/event.py b/fluent/event.py
@@ -4,6 +4,6 @@
 class Event(object):
     def __init__(self, label, data, **kwargs):
         assert isinstance(data, dict), 'data must be a dict'
-        s = kwargs.get('sender', sender.get_global_sender())
+        sender_ = kwargs.get('sender', sender.get_global_sender())
         timestamp = kwargs.get('time', int(time.time()))
-        s.emit_with_time(label, timestamp, data)
+        sender_.emit_with_time(label, timestamp, data)
diff --git a/fluent/handler.py b/fluent/handler.py
@@ -39,10 +39,11 @@ def _structuring(self, data, msg):
             except (ValueError, json.JSONDecodeError):
                 pass
 
-    def _add_dic(self, data, dic):
-        for k, v in dic.items():
-            if isinstance(k, basestring):
-                data[str(k)] = v
+    @staticmethod
+    def _add_dic(data, dic):
+        for key, value in dic.items():
+            if isinstance(key, basestring):
+                data[str(key)] = value
 
 class FluentHandler(logging.Handler):
     '''
@@ -63,7 +64,8 @@ def __init__(self,
         logging.Handler.__init__(self)
 
     def emit(self, record):
-        if record.levelno < self.level: return
+        if record.levelno < self.level:
+            return
         data = self.fmt.format(record)
         self.sender.emit(None, data)
 
