Add unit tests for Asset#delete

sigmavirus24 · sigmavirus24 · commit b59932841bf1 · 2015-01-07T22:36:18.000-06:00
diff --git a/github3/repos/release.py b/github3/repos/release.py
@@ -154,8 +154,6 @@ def upload_asset(self, content_type, name, asset):
 
 class Asset(GitHubCore):
 
-    CUSTOM_HEADERS = {'Accept': 'application/vnd.github.manifold-preview'}
-
     def _update_attributes(self, asset):
         self._api = asset.get('url')
         #: Content-Type provided when the asset was created
@@ -223,7 +221,7 @@ def delete(self):
         """
         url = self._api
         return self._boolean(
-            self._delete(url, headers=Asset.CUSTOM_HEADERS),
+            self._delete(url, headers=Release.CUSTOM_HEADERS),
             204,
             404
         )
diff --git a/tests/unit/test_repos_release.py b/tests/unit/test_repos_release.py
@@ -91,6 +91,15 @@ class TestAsset(UnitHelper):
         "updated_at": "2013-02-27T19:35:32Z"
         }
 
+    def test_delete(self):
+        """Verify the request to delete an Asset."""
+        self.instance.delete()
+
+        self.session.delete.assert_called_once_with(
+            url_for('/assets/1'),
+            headers=Release.CUSTOM_HEADERS
+        )
+
     @pytest.mark.xfail
     def test_download(self):
         """Verify the request to download an Asset file."""

Original file line number	Diff line number	Diff line change
`@@ -154,8 +154,6 @@ def upload_asset(self, content_type, name, asset):`
`154`	`154`
`155`	`155`	`class Asset(GitHubCore):`
`156`	`156`
`157`		`- CUSTOM_HEADERS = {'Accept': 'application/vnd.github.manifold-preview'}`
`158`		`-`
`159`	`157`	`def _update_attributes(self, asset):`
`160`	`158`	`self._api = asset.get('url')`
`161`	`159`	`#: Content-Type provided when the asset was created`
`@@ -223,7 +221,7 @@ def delete(self):`
`223`	`221`	`"""`
`224`	`222`	`url = self._api`
`225`	`223`	`return self._boolean(`
`226`		`- self._delete(url, headers=Asset.CUSTOM_HEADERS),`
	`224`	`+ self._delete(url, headers=Release.CUSTOM_HEADERS),`
`227`	`225`	`204,`
`228`	`226`	`404`
`229`	`227`	`)`