From c9708e65e8d02c1bf140b7ef9d16a715394757ce Mon Sep 17 00:00:00 2001 From: Jukka Raimovaara Date: Wed, 20 Nov 2024 11:57:55 +0200 Subject: [PATCH 1/4] fix few refs --- .../src/components/BDropdown/BDropdown.vue | 9 +++++---- .../src/components/BPopover/BPopover.vue | 10 ++++++---- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/packages/bootstrap-vue-next/src/components/BDropdown/BDropdown.vue b/packages/bootstrap-vue-next/src/components/BDropdown/BDropdown.vue index 80550f4ee..216236be0 100644 --- a/packages/bootstrap-vue-next/src/components/BDropdown/BDropdown.vue +++ b/packages/bootstrap-vue-next/src/components/BDropdown/BDropdown.vue @@ -86,6 +86,7 @@ import { provide, ref, toRef, + useTemplateRef, watch, } from 'vue' import {useDefaults} from '../../composables/useDefaults' @@ -177,10 +178,10 @@ const computedOffset = computed(() => ) const offsetToNumber = useToNumber(computedOffset) -const floating = ref(null) -const button = ref(null) -const splitButton = ref(null) -const wrapper = ref(null) +const floating = useTemplateRef('floating') +const button = useTemplateRef('button') +const splitButton = useTemplateRef('splitButton') +const wrapper = useTemplateRef('wrapper') const boundary = computed(() => isBoundary(props.boundary) ? props.boundary : undefined diff --git a/packages/bootstrap-vue-next/src/components/BPopover/BPopover.vue b/packages/bootstrap-vue-next/src/components/BPopover/BPopover.vue index a3c64de89..86b4004e5 100644 --- a/packages/bootstrap-vue-next/src/components/BPopover/BPopover.vue +++ b/packages/bootstrap-vue-next/src/components/BPopover/BPopover.vue @@ -75,6 +75,7 @@ import { ref, toRef, toValue, + useTemplateRef, watch, } from 'vue' import {useDefaults} from '../../composables/useDefaults' @@ -165,10 +166,11 @@ const computedId = useId(() => props.id, 'popover') const hidden = ref(false) -const element = ref(null) -const content = ref(null) -const arrow = ref(null) -const placeholder = ref(null) +const element = useTemplateRef('element') +const content = useTemplateRef('content') +const arrow = useTemplateRef('arrow') +const placeholder = useTemplateRef('placeholder') + const floatingTarget = ref(null) const trigger = ref(null) From 6cedefae820e9c47f6d84e21ca3b4e67e4a289af Mon Sep 17 00:00:00 2001 From: Jukka Raimovaara Date: Wed, 20 Nov 2024 12:10:05 +0200 Subject: [PATCH 2/4] change all the refs to include _ at the begining --- .../src/components/BAlert/BAlert.vue | 4 ++-- .../src/components/BButton/BButton.vue | 2 +- .../src/components/BCarousel/BCarousel.vue | 15 ++++++++++----- .../src/components/BCollapse/BCollapse.vue | 4 ++-- .../src/components/BDropdown/BDropdown.vue | 14 ++++++-------- .../src/components/BForm/BForm.vue | 4 ++-- .../components/BFormCheckbox/BFormCheckbox.vue | 4 ++-- .../BFormCheckbox/BFormCheckboxGroup.vue | 4 ++-- .../src/components/BFormFile/BFormFile.vue | 2 +- .../src/components/BFormGroup/BFormGroup.vue | 6 +++--- .../src/components/BFormInput/BFormInput.vue | 2 +- .../src/components/BFormRadio/BFormRadio.vue | 4 ++-- .../components/BFormRadio/BFormRadioGroup.vue | 4 ++-- .../src/components/BFormSelect/BFormSelect.vue | 4 ++-- .../BFormSpinbutton/BFormSpinbutton.vue | 4 ++-- .../src/components/BFormTags/BFormTags.vue | 2 +- .../components/BFormTextarea/BFormTextarea.vue | 2 +- .../src/components/BModal/BModal.vue | 18 +++++++++--------- .../src/components/BNav/BNavItemDropdown.vue | 2 +- .../src/components/BOffcanvas/BOffcanvas.vue | 8 ++++---- .../src/components/BPagination/BPagination.vue | 2 +- .../src/components/BPopover/BPopover.vue | 16 ++++++++-------- .../src/components/BTabs/BTab.vue | 2 +- .../src/components/BToast/BToast.vue | 4 ++-- .../src/components/BTooltip/BTooltip.vue | 2 +- 25 files changed, 69 insertions(+), 66 deletions(-) diff --git a/packages/bootstrap-vue-next/src/components/BAlert/BAlert.vue b/packages/bootstrap-vue-next/src/components/BAlert/BAlert.vue index 8da80d102..b146e7414 100644 --- a/packages/bootstrap-vue-next/src/components/BAlert/BAlert.vue +++ b/packages/bootstrap-vue-next/src/components/BAlert/BAlert.vue @@ -2,7 +2,7 @@