8000 Refactor: consistent composable for show/hide, composable for managing lazy states, add prop back for "visible" · Issue #2283 · bootstrap-vue-next/bootstrap-vue-next · GitHub
[go: up one dir, main page]

Skip to content
Refactor: consistent composable for show/hide, composable for managing lazy states, add prop back for "visible" #2283
Closed
@xvaara

Description

@xvaara

Hey, part of the rewrite for show/hide PR I got to think about those props.

They don't all work the same way, so I'd like to define how they should work, so that I can make all them coherent.

My proposal:

  1. If modelValue is true, we animete the element in. (of course no animation if that prop is set)
  2. toggle is true -> in onMount we set modelValue to true and animate
  3. visible is true -> we set modelValue true and display the component without animation (as it would have been open already)

visible takes priority over toggle. Both props are reactive and act as described when changed.

@VividLemon @dwgray thoughts? few of the components (collapse ie) already work like this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    questionFurther information is requested

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0