RFC: BFormFile closer to Bootstrap-vue? #1213
VividLemon
started this conversation in
Polls
Replies: 2 comments
-
|
Could we not do both, have a "Lite" version without of this added functionality? |
Beta Was this translation helpful? Give feedback.
0 replies
-
|
IMO, if BFormFile does not provide more customizations compare to plain HTML |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Bootstrap-vue's implementation of BFormFile was due to Bootstrap v4 not having a "nice looking" appearance for file inputs. In Bootstrap v4, the appearance is what Bootstrap-vue's BFormFile looks like with their prop 'plain' activated.
Yuck!
Bootstrap v5 by default includes a better style for this.
I like this style, and it takes little to build and maintain, as the browser does most of the heavy lifting.
However, the current implementation of BFormFile on Bootstrap-vue-next lacks some of the features that bootstrap-vue has. Namely, visual feedback for drag/drop support (which can be added without any other major changes).
Particularly, the biggest issue is changing the "browse" button on the side, and the text on the inside. This is not bootstrap's responsibility, this is solely on the browser.
The way Bootstrap-vue, and many other css frameworks (like Vuetify), solve this by essentially creating an invisible input element, then show a element above that input element that can then modify the text on the inside... Super hacky!
The question is, do we implement this hack, which will cause much more bloat (perhaps around 40% larger size with everything said and done), or do we simply leave it how it is now?
The features that would be implemented are:
So the question is, is it really worth the effort when the default behavior looks just as good?
41 votes ·
Beta Was this translation helpful? Give feedback.
All reactions