fix(b-link): don't render target or rel attrs when router-tag other than a or area provided (#5107)

tmorehouse · web-flow · commit 33c6cefc2f46 · 2020-04-06T15:18:49.000-03:00
Co-authored-by: Jacob Müller
diff --git a/src/components/link/link.js b/src/components/link/link.js
@@ -149,23 +149,19 @@ export const BLink = /*#__PURE__*/ Vue.extend({
     }
   },
   render(h) {
+    const { active, disabled, target, routerTag, isRouterLink } = this
     const tag = this.computedTag
     const rel = this.computedRel
     const href = this.computedHref
-    const isRouterLink = this.isRouterLink
 
     const componentData = {
-      class: { active: this.active, disabled: this.disabled },
+      class: { active, disabled },
       attrs: {
         ...this.$attrs,
-        rel,
-        target: this.target,
-        tabindex: this.disabled
-          ? '-1'
-          : isUndefined(this.$attrs.tabindex)
-            ? null
-            : this.$attrs.tabindex,
-        'aria-disabled': this.disabled ? 'true' : null
+        // We don't render `rel` or `target` on non link tags when using `vue-router`
+        ...(isRouterLink && routerTag !== 'a' && routerTag !== 'area' ? {} : { rel, target }),
+        tabindex: disabled ? '-1' : isUndefined(this.$attrs.tabindex) ? null : this.$attrs.tabindex,
+        'aria-disabled': disabled ? 'true' : null
       },
       props: this.computedProps
     }
