dynamic_cast before destructor

vitalybuka · stefanseefeld · commit ff0ae9b29d77 · 2024-09-22T12:30:12.000-04:00
Call to the destructor ends lifetime of the object, including vptr
used by dynamic_cast.
diff --git a/src/object/class.cpp b/src/object/class.cpp
@@ -333,8 +333,9 @@ namespace objects
           for (instance_holder* p = kill_me->objects, *next; p != 0; p = next)
           {
               next = p->next();
+              void* q = dynamic_cast<void*>(p);
               p->~instance_holder();
-              instance_holder::deallocate(inst, dynamic_cast<void*>(p));
+              instance_holder::deallocate(inst, q);
           }
         
           // Python 2.2.1 won't add weak references automatically when

Original file line number	Diff line number	Diff line change
`@@ -333,8 +333,9 @@ namespace objects`
`333`	`333`	`for (instance_holder* p = kill_me->objects, *next; p != 0; p = next)`
`334`	`334`	`{`
`335`	`335`	`next = p->next();`
	`336`	`+ void* q = dynamic_cast<void*>(p);`
`336`	`337`	`p->~instance_holder();`
`337`		`- instance_holder::deallocate(inst, dynamic_cast<void*>(p));`
	`338`	`+ instance_holder::deallocate(inst, q);`
`338`	`339`	`}`
`339`	`340`
`340`	`341`	`// Python 2.2.1 won't add weak references automatically when`