8000 Fix WebGL marker count change by ianthomas23 · Pull Request #11686 · bokeh/bokeh · GitHub
[go: up one dir, main page]
Skip to content

Fix WebGL marker count change #11686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mattpap merged 3 commits into from
Sep 27, 2021
Merged

Fix WebGL marker count change #11686

mattpap merged 3 commits into from
Sep 27, 2021

Conversation

@ianthomas23
Copy link
Member
@ianthomas23 ianthomas23 commented Sep 27, 2021

Fixes bug that occurs in WebGL when the number of markers/rects is changed under certain circumstances none of them are displayed. It was an error of omission in an if..then block.

Fix is the same for both markers and rects. This duplication will be removed when they are combined (WebGL roadmap discussion #11369 item 5).

I have added a test for rect only but manually checked marker too.

mattpap
mattpap reviewed Sep 27, 2021
View reviewed changes
mattpap
mattpap reviewed Sep 27, 2021
View reviewed changes
mattpap
mattpap reviewed Sep 27, 2021
View reviewed changes
@mattpap mattpap added this to the 3.0 milestone Sep 27, 2021
@mattpap mattpap mentioned this pull request Sep 27, 2021
Merged
@mattpap mattpap merged commit 6c48222 into bokeh:branch-3.0 Sep 27, 2021
bryevdv pushed a commit that referenced this pull request Sep 27, 2021
@ianthomas23 @bryevdv
Fix WebGL marker count change (#11686)
fedbe7a 
* Fix WebGL marker count change

* Add test

* Address review comments
bryevdv pushed a commit that referenced this pull request Sep 27, 2021
@ianthomas23 @bryevdv
Fix WebGL marker count change (#11686)
866015b 
* Fix WebGL marker count change

* Add test

* Address review comments
@bryevdv bryevdv modified the milestones: 3.0, 2.4.1 Sep 27, 2021
This was referenced Sep 29, 2021
Closed
Merged
@mattpap mattpap mentioned this pull request Oct 28, 2021
Closed
bryevdv pushed a commit that referenced this pull request Dec 13, 2021
@ianthomas23 @bryevdv
Fix WebGL marker count change (#11686)
bba1cef 
* Fix WebGL marker count change

* Add test

* Address review comments
@github-actions
Copy link
github-actions bot commented Oct 26, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mattpap mattpap mattpap left review comments

Assignees

No one assigned

Labels

status: accepted

Projects

None yet

Milestone

2.4.1

Development

Successfully merging this pull request may close these issues.

[BUG] Parallel Plot example with output_backend="webgl" not working

3 participants

@ianthomas23 @mattpap @bryevdv
0