-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
TeX on Markup widgets Div, Paragraph #11585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Member
|
(Narrative) documentation will be included in #11544 |
mattpap
reviewed
Sep 11, 2021
mattpap
reviewed
Sep 11, 2021
mattpap
reviewed
Sep 11, 2021
mattpap
reviewed
Sep 11, 2021
mattpap
reviewed
Sep 11, 2021
mattpap
reviewed
Sep 11, 2021
mattpap
reviewed
Sep 11, 2021
mattpap
reviewed
Sep 11, 2021
mattpap
reviewed
Sep 11, 2021
mattpap
reviewed
Sep 11, 2021
bryevdv
reviewed
Sep 11, 2021
bryevdv
reviewed
Sep 11, 2021
mattpap
reviewed
Sep 13, 2021
mattpap
reviewed
Sep 13, 2021
mattpap
reviewed
Sep 13, 2021
mattpap
reviewed
Sep 13, 2021
mattpap
reviewed
Sep 13, 2021
mattpap
reviewed
Sep 13, 2021
mattpap
reviewed
Sep 13, 2021
mattpap
reviewed
Sep 13, 2021
Contributor
|
We've just discussed the remaining required changes, so this should be finished soon. |
Member
Member
|
@mattpap is this good to merge now? I would like to cut the RC today if possible |
1 task
7 tasks
bryevdv
pushed a commit
that referenced
this pull request
Dec 13, 2021
* TeX working on div widgets * add missing inline prop to bokeh * baselins for tex on div * check for property exist instead of getting all property values * restore default options * use mathjax namespace * export mathjax provider * update div imports * remove log and unnecessary filter * update mathjax namespace * update find math function * unit tests find_math_parts * update docstrings * check for mathstrings by default; have a disable flag * update markups to accept tex * update import order * update baselines * remove outdated baselines * change is_tex_string to contains_tex_string * give latex tests some threshold * threshold fix * fix wrong style on paragraph * remove needless thresholds * removed tex support from pre * Fix typo * smaller sample text for pre test not latex * update pre baselines * use doublequotes * snake case * remove random whitespace * update docstrings * replace find math with regexs and mathjax implementation * move processing of tex to views * output which tests has caused errors * update contains_tex check * check if parts are undefined * update docstrings * add line between tests * remove test description * rename find_math to find_tex * remove todo warning * remove needless regex flag * update provider interaction * make code consistent with other markups
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion on bundler and finding mathstrings #11589