mining: add coinbase locktime, sequence and version fields to getblocktemplate RPC #34419
+21
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34419. ReviewsSee the guideline for information on the review process. |
Expand the getblocktemplate RPC result with two fields to prepare for a possible BIP54 deployment in the future.
a857fe7 to
90025e8
Compare
Member
Author
|
Added the coinbase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BIP54 proposes contraining the cointbase transaction
nLockTimeandnSequencefields. Our internal mining code has been doing this since miner: timelock the coinbase to the mined block's height #32155, but currently the fields are only communicated to IPC clients (see e.g. mining: getCoinbase() returns struct instead of raw tx #33819).Additionally this PR adds the
nVersionfield. This is unrelated to BIP54, but it meansgetblocktemplatenow covers all coinbase transaction fields.Typically adding new fields to the
getblocktemplateinvolves a BIP, so I'll keep this in draft while I write one. WIP: Sjors/bips#1