fix: Without any setActive for rtc session, libwebrtc manages the session counter by itself. (flutter-webrtc#1266)

cloudwebrtc · web-flow · commit 28f994b8ee40 · 2023-02-14T14:45:02.000+08:00
diff --git a/common/darwin/Classes/AudioUtils.m b/common/darwin/Classes/AudioUtils.m
@@ -74,13 +74,6 @@ + (void)setSpeakerphoneOn:(BOOL)enable {
                                                  error:&error];
     if (!success)
       NSLog(@"Port override failed due to: %@", error);
-
-    success = [session setActive:YES error:&error];
-    if (!success)
-      NSLog(@"Audio session override failed: %@", error);
-    else
-      NSLog(@"AudioSession override via Earpiece/Headset is successful ");
-
   } else {
     [session setMode:config.mode error:&error];
     BOOL success = [session setCategory:config.category
@@ -94,12 +87,6 @@ + (void)setSpeakerphoneOn:(BOOL)enable {
                                          error:&error];
     if (!success)
       NSLog(@"Port override failed due to: %@", error);
-
-    success = [session setActive:YES error:&error];
-    if (!success)
-      NSLog(@"Audio session override failed: %@", error);
-    else
-      NSLog(@"AudioSession override via Loudspeaker is successful ");
   }
   [session unlockForConfiguration];
 }
@@ -108,11 +95,13 @@ + (void)deactiveRtcAudioSession {
     NSError* error = nil;
     RTCAudioSession* session = [RTCAudioSession sharedInstance];
     [session lockForConfiguration];
-    BOOL success = [session setActive:NO error:&error];
-    if (!success)
-        NSLog(@"RTC Audio session deactive failed: %@", error);
-    else
-        NSLog(@"RTC AudioSession deactive is successful ");
+    if([session isActive]) {
+      BOOL success = [session setActive:NO error:&error];
+      if (!success)
+          NSLog(@"RTC Audio session deactive failed: %@", error);
+      else
+          NSLog(@"RTC AudioSession deactive is successful ");
+    }
     [session unlockForConfiguration];
 }
 
