fix(node-fetch): Use stringified origin url (getsentry#13581)

s1gr1d · web-flow · commit 70f938b75ae8 · 2024-09-04T12:04:27.000+02:00
Uses the stringified value of `origin` to call `.endsWith()`. closes getsentry#13574
diff --git a/packages/node/src/integrations/node-fetch.ts b/packages/node/src/integrations/node-fetch.ts
@@ -192,11 +192,11 @@ function getBreadcrumbData(request: FetchRequest): Partial<SanitizedRequestData>
 function getAbsoluteUrl(origin: string, path: string = '/'): string {
   const url = `${origin}`;
 
-  if (origin.endsWith('/') && path.startsWith('/')) {
+  if (url.endsWith('/') && path.startsWith('/')) {
     return `${url}${path.slice(1)}`;
   }
 
-  if (!origin.endsWith('/') && !path.startsWith('/')) {
+  if (!url.endsWith('/') && !path.startsWith('/')) {
     return `${url}/${path.slice(1)}`;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -192,11 +192,11 @@ function getBreadcrumbData(request: FetchRequest): Partial<SanitizedRequestData>`
`192`	`192`	`function getAbsoluteUrl(origin: string, path: strin 8241 g = '/'): string {`
`193`	`193`	const url = `${origin}`;
`194`	`194`
`195`		`- if (origin.endsWith('/') && path.startsWith('/')) {`
	`195`	`+ if (url.endsWith('/') && path.startsWith('/')) {`
`196`	`196`	return `${url}${path.slice(1)}`;
`197`	`197`	`}`
`198`	`198`
`199`		`- if (!origin.endsWith('/') && !path.startsWith('/')) {`
	`199`	`+ if (!url.endsWith('/') && !path.startsWith('/')) {`
`200`	`200`	return `${url}/${path.slice(1)}`;
`201`	`201`	`}`
`202`	`202`