Change exemplar length limit to be only for label names+values (prometheus#397)

brian-brazil · web-flow · commit 31f5557e2e84 · 2019-04-12T10:38:16.000+01:00
Per recent discussions.

Signed-off-by: Brian Brazil &lt;brian.brazil@robustperception.io&gt;
diff --git a/prometheus_client/openmetrics/parser.py b/prometheus_client/openmetrics/parser.py
@@ -222,7 +222,7 @@ def _parse_sample(text):
     ts = _parse_timestamp(timestamp)
     exemplar = None
     if exemplar_labels is not None:
-        exemplar_length = sum([len(k) + len(v) + 3 for k, v in exemplar_labels.items()]) + 2
+        exemplar_length = sum([len(k) + len(v) for k, v in exemplar_labels.items()])
         if exemplar_length > 64:
             raise ValueError("Exmplar labels are too long: " + text)
         exemplar = Exemplar(
diff --git a/tests/openmetrics/test_parser.py b/tests/openmetrics/test_parser.py
@@ -518,7 +518,7 @@ def test_invalid_input(self):
             ('# TYPE a histogram\na_bucket{le="+Inf"} 1 # {} 1 \n# EOF\n'),
             ('# TYPE a histogram\na_bucket{le="+Inf"} 1 # {} 1 1 \n# EOF\n'),
             ('# TYPE a histogram\na_bucket{le="+Inf"} 1 # '
-             '{a="12345678901234567890123456789012345678901234567890123456789"} 1 1\n# EOF\n'),
+             '{a="2345678901234567890123456789012345678901234567890123456789012345"} 1 1\n# EOF\n'),
             # Exemplars on unallowed samples.
             ('# TYPE a histogram\na_sum 1 # {a="b"} 0.5\n# EOF\n'),
             ('# TYPE a gaugehistogram\na_sum 1 # {a="b"} 0.5\n# EOF\n'),
