Implement package exports and subpath imports handling #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@bennycode 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Co-authored-by: bennycode <469989+bennycode@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Uncovered cases explored from a project migration
Implement package exports and subpath imports handling
Aug 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements smart handling of package exports and subpath imports to distinguish between legacy packages that need
.jsextensions and modern packages withexportsfield that should remain unchanged.Problem
The current implementation adds
.jsextensions to all node_modules imports, but this doesn't work correctly for modern packages that use theexportsfield in theirpackage.json. This causes issues where:lodash) need.jsextensions:'lodash/omit'→'lodash/omit.js'firebase-functions) should remain unchanged:'firebase-functions/v1/https'(already works correctly in ESM)Solution
Added intelligent package detection that checks if a node_modules package has an
exportsfield:Key Changes
hasPackageExports()utility inPathUtil.tsthat safely reads and parsespackage.jsonfiles to detect theexportsfieldreplaceModulePath.tsto check package exports before adding file extensions@types/nodeTesting
This change maintains full backward compatibility while fixing the issue with modern packages that use the
exportsfield.Fixes #129.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.