Call dialog.close() in onFormClose and onFormSubmitted callbacks for createForm forms

spalmurray · spalmurray · commit f9a040a83038 · 2024-08-02T14:11:30.000-04:00
diff --git a/packages/feedback/src/core/integration.ts b/packages/feedback/src/core/integration.ts
@@ -318,7 +318,21 @@ export const buildFeedbackIntegration = ({
       async createForm(
         optionOverrides: OverrideFeedbackConfiguration = {},
       ): Promise<ReturnType<FeedbackModalIntegration['createDialog']>> {
-        return _loadAndRenderDialog(mergeOptions(_options, optionOverrides));
+        const mergedOptions = mergeOptions(_options, optionOverrides);
+
+        const dialog = await _loadAndRenderDialog({
+          ...mergedOptions,
+          onFormClose: () => {
+            dialog && dialog.close();
+            mergedOptions.onFormClose && mergedOptions.onFormClose();
+          },
+          onFormSubmitted: () => {
+            dialog && dialog.close();
+            mergedOptions.onFormSubmitted && mergedOptions.onFormSubmitted();
+          },
+        });
+
+        return dialog;
       },
 
       /**
