add deprecation warning for orderby reverse

yyx990803 · yyx990803 · commit e0810528761b · 2015-10-09T17:07:23.000-04:00
diff --git a/src/deprecations.js b/src/deprecations.js
@@ -258,6 +258,13 @@ if (process.env.NODE_ENV !== 'production') {
         'vm.$addChild() will be deprecated in 1.0.0. Use the `parent` option ' +
         'instead. (Note the `parent` option does not work with `inherit: true`)'
       )
+    },
+
+    ORDER_BY_REVERSE: function () {
+      warn(
+        'The "orderBy" filter\'s reverse argument is expected to be a number in 1.0.0. ' +
+        'A number smaller than 0 indicates the output should be in descending order.'
+      )
     }
 
   }
diff --git a/src/filters/array-filters.js b/src/filters/array-filters.js
@@ -62,6 +62,11 @@ exports.orderBy = function (arr, sortKey, reverse) {
   if (!sortKey) {
     return arr
   }
+  if (process.env.NODE_ENV !== 'production') {
+    if (arguments.length > 2 && typeof reverse !== 'number') {
+      _.deprecation.ORDER_BY_REVERSE()
+    }
+  }
   var order = (reverse && reverse < 0) ? -1 : 1
   // sort on a copy to avoid mutating original array
   return arr.slice().sort(function (a, b) {

Original file line number	Diff line number	Diff line change
`@@ -258,6 +258,13 @@ if (process.env.NODE_ENV !== 'production') {`
`258`	`258`	'vm.$addChild() will be deprecated in 1.0.0. Use the `parent` option ' +
`259`	`259`	'instead. (Note the `parent` option does not work with `inherit: true`)'
`260`	`260`	`)`
	`261`	`+ },`
	`262`	`+`
	`263`	`+ ORDER_BY_REVERSE: function () {`
	`264`	`+ warn(`
	`265`	`+ 'The "orderBy" filter\'s reverse argument is expected to be a number in 1.0.0. ' +`
	`266`	`+ 'A number smaller than 0 indicates the output should be in descending order.'`
	`267`	`+ )`
`261`	`268`	`}`
`262`	`269`
`263`	`270`	`}`