8000 Comparing master...broken-routes · beepscore/remy_python · GitHub
[go: up one dir, main page]
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: beepscore/remy_python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: beepscore/remy_python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: broken-routes
Choose a head ref
  • 7 commits
  • 3 files changed
  • 1 contributor

Commits on Apr 24, 2019

  1. Add flask_util.py

    @beepscore
    beepscore committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    dacbc01 View commit details
    Browse the repository at this point in the history

  2. In service.py use flask_util

    @beepscore
    beepscore committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    d5d3a18 View commit details
    Browse the repository at this point in the history

  3. In volume_decrease_increase return a value. # TODO: check if returnin… 

    …g here fixes ValueError: View function did not return a response

https://stackoverflow.com/questions/25034123/flask-value-error-view-function-did-not-return-a-response
    @beepscore
    beepscore committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    12301f3 View commit details
    Browse the repository at this point in the history

  4. Update reference to API_NAME

    @beepscore
    beepscore committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    a4399d6 View commit details
    Browse the repository at this point in the history

  5. Attempt to fix broken routes, probably due to enum. e.g. 404 Client E… 

    …rror: NOT FOUND for url: http://10.0.0.4:5000/api/v1/tv/volume-decrease-increase/.
    @beepscore
    beepscore committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    744ab38 View commit details
    Browse the repository at this point in the history

  6. Revert "Attempt to fix broken routes, probably due to enum. e.g. 404 … 

    …Client Error: NOT FOUND for url: http://10.0.0.4:5000/api/v1/tv/volume-decrease-increase/."

This reverts commit 744ab38.
    @beepscore
    beepscore committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    379b2d4 View commit details
    Browse the repository at this point in the history

  7. Still trying to fix broken routes. Remove ServiceConstants enum.

    @beepscore
    beepscore committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    1dae75e View commit details
    Browse the repository at this point in the history
Loading
0