Add test to demonstrate that AsyncHttpClient#1134 is fixed in AHC2

slandelle · slandelle · commit b42c256ff0b3 · 2016-05-23T22:31:04.000+02:00
diff --git a/client/src/test/java/org/asynchttpclient/BasicHttpTest.java b/client/src/test/java/org/asynchttpclient/BasicHttpTest.java
@@ -15,7 +15,7 @@
 
 import static io.netty.handler.codec.http.HttpHeaders.Names.*;
 import static io.netty.handler.codec.http.HttpHeaders.Values.*;
-import static java.nio.charset.StandardCharsets.*;
+import static java.nio.charset.StandardCharsets.ISO_8859_1;
 import static java.util.concurrent.TimeUnit.SECONDS;
 import static org.asynchttpclient.Dsl.*;
 import static org.asynchttpclient.test.TestUtils.*;
@@ -41,6 +41,8 @@
 import java.util.concurrent.atomic.AtomicInteger;
 import java.util.concurrent.atomic.AtomicReference;
 
+import javax.net.ssl.SSLException;
+
 import org.asynchttpclient.cookie.Cookie;
 import org.asynchttpclient.handler.MaxRedirectException;
 import org.asynchttpclient.request.body.multipart.StringPart;
@@ -893,4 +895,20 @@ public void newConnectionEventsAreFired() throws Throwable {
             });
         });
     }
+
+    @Test
+    public void requestingPlainHttpEndpointOverHttpsThrowsSslException() throws Throwable {
+        withClient().run(client -> {
+            withServer(server).run(server -> {
+                server.enqueueEcho();
+                try {
+                    client.prepareGet(getTargetUrl().replace("http", "https")).execute().get();
+                    fail("Request shouldn't succeed");
+                } catch (ExecutionException e) {
+                    assertTrue(e.getCause() instanceof ConnectException, "Cause should be a ConnectException");
+                    assertTrue(e.getCause().getCause() instanceof SSLException, "Root cause should be a SslException");
+                }
+            });
+        });
+    }
 }
