Fix ArduinoStreamReader::read(), returns wrong values for signed char #1118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3703d08 to
801dd63
Compare
bblanchon
added a commit
that referenced
this pull request
Oct 29, 2019
|
Thank you very much for catching this bug @mikee47. |
|
Fix published in ArduinoJson 6.13.0 |
Repository owner
locked and limited conversation to collaborators
Nov 29, 2019
stawiski
pushed a commit
to stawiski/ArduinoJson
that referenced
this pull request
Jul 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is potentially a more complex problem... Affects MsgPack deserialization.