8000 Ensure deterministic ordering of package dependencies by whl.py by thundergolfer · Pull Request #328 · bazel-contrib/rules_python · GitHub
[go: up one dir, main page]
Skip to content

Ensure deterministic ordering of package dependencies by whl.py #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2020
Merged

Ensure deterministic ordering of package dependencies by whl.py #328

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd0cd91
Address https://github.com/bazelbuild/rules_python/issues/289
thundergolfer-two Jun 14, 2020
264fb30
Merge branch 'master' into jonathon--deterministic-dependency-set-iss…
andyscott Jun 24, 2020
4a212ba
Merge branch 'master' into jonathon--deterministic-dependency-set-iss…
andyscott Jun 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packaging/whl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def dependencies(self, extra=None):
of the named "extra".

Yields:
the names of requirements from the metadata.json
the names of requirements from the metadata.json, in lexical order.
"""
# TODO(mattmoor): Is there a schema to follow for this?
dependency_set = set()
Expand All @@ -101,7 +101,7 @@ def dependencies(self, extra=None):
parts = re.split('[ ><=()]', entry)
dependency_set.add(parts[0])

return dependency_set
return sorted(dependency_set)

def extras(self):
return self.metadata().get('extras', [])
Expand Down
0