8000 Dependencies are not when using wheels on a different platform · Issue #1591 · bazel-contrib/rules_python · GitHub
[go: up one dir, main page]

Skip to content
Dependencies are not when using wheels on a different platform #1591
Closed
@aignas

Description

@aignas

🐞 bug report

Affected Rule

pip_parse, whl_library.

Is this a regression?

No.

Description

Fetching a whl using download_only = True one would expect to get the
dependencies for the target platform as specified by the extra variable that
one has to pass as described in
this bazelcon talk.
However, for pytorch 2.0, linux wheels depend on an extra wheel that is a
linux only wheel and it never gets into the dependency closure when the
whl_library gets setup due to
this line.
This means that the output of the whl_library will be host platform specific,
which may break in situations when building a docker image with rules_oci or
similar.

This behaviour is related to #260, but much smaller in scope.

🔬 Minimal Reproduction

Setup a whl_library with click and observe, that there is no conditional
dependency for the Windows platform.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0