fix(whl_library): fix ABI parsing for exotic wheel platforms

aignas · aignas · commit 430d62c2d302 · 2024-02-09T16:09:47.000+09:00
In addition to the regular `cp39_linux_x86_64` or `linux_x86_64`
we need to also handle the `abi3_linux_x86_64` and `none_linux_x86_64`.
diff --git a/python/pip_install/tools/wheel_installer/wheel.py b/python/pip_install/tools/wheel_installer/wheel.py
@@ -191,11 +191,14 @@ def from_string(cls, platform: Union[str, List[str]]) -> List["Platform"]:
                 continue
 
             abi, _, tail = p.partition("_")
-            if not abi.startswith("cp"):
+            if abi in ["abi3", "none"]:
+                abi = ""
+            elif not abi.startswith("cp"):
                 # The first item is not an abi
                 tail = p
                 abi = ""
             os, _, arch = tail.partition("_")
+            print(abi, os, arch)
             arch = arch or "*"
 
             minor_version = int(abi[len("cp3") :]) if abi else None
diff --git a/python/pip_install/tools/wheel_installer/wheel_test.py b/python/pip_install/tools/wheel_installer/wheel_test.py
@@ -290,9 +290,14 @@ def test_can_get_host(self):
         self.assertEqual(host, wheel.Platform.from_string("host"))
 
     def test_can_get_linux_x86_64_without_py_version(self):
-        got = wheel.Platform.from_string("linux_x86_64")
-        want = wheel.Platform(os=wheel.OS.linux, arch=wheel.Arch.x86_64)
-        self.assertEqual(want, got[0])
+        for input in [
+            "linux_x86_64",
+            "abi3_linux_x86_64",
+            "none_linux_x86_64",
+        ]:
+            got = wheel.Platform.from_string(input)
+            want = wheel.Platform(os=wheel.OS.linux, arch=wheel.Arch.x86_64)
+            self.assertEqual(want, got[0])
 
     def test_can_get_specific_from_string(self):
         got = wheel.Platform.from_string("cp33_linux_x86_64")
