8000 refactor: move twine deps to its own folder · bazel-contrib/rules_python@192c34a · GitHub
[go: up one dir, main page]
Skip to content

Commit 192c34a

Browse files
alexeaglealexeagle
committed
refactor: move twine deps to its own folder
1 parent b7b1698 commit 192c34a

File tree

7 files changed

+14
-12
lines changed

7 files changed

+14
-12
lines changed

‎WORKSPACE

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,19 +68,18 @@ load("@rules_python_gazelle_plugin//:deps.bzl", _py_gazelle_deps = "gazelle_deps
6868
# for python requirements.
6969
_py_gazelle_deps()
7070

71-
load("@python//3.11.1:defs.bzl", "interpreter")
72-
7371
#####################
7472
# Install twine for our own runfiles wheel publishing
7573
# Eventually we might want to install twine automatically for users too, see:
7674
# See https://github.com/bazelbuild/rules_python/issues/1016
75+
load("@python//3.11.1:defs.bzl", "interpreter")
7776
load("@rules_python//python:pip.bzl", "pip_parse")
7877

7978
pip_parse(
8079
name = "publish_deps",
8180
python_interpreter_target = interpreter,
82-
requirements_lock = "//python/runfiles:requirements.txt",
83-
requirements_windows = "//python/runfiles:requirements_windows.txt",
81+
requirements_lock = "//tools/publish:requirements.txt",
82+
requirements_windows = "//tools/publish:requirements_windows.txt",
8483
)
8584

8685
load("@publish_deps//:requirements.bzl", "install_deps")

‎python/runfiles/BUILD.bazel

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,6 @@
1414

1515
load("//python:defs.bzl", "py_binary", "py_library")
1616
load("//python:packaging.bzl", "py_wheel")
17-
load("//python:pip.bzl", "compile_pip_requirements")
18-
19-
compile_pip_requirements(
20-
name = "requirements",
21-
requirements_windows = "requirements_windows.txt",
22-
# This fails on RBE and MacOS right now, and we don't need coverage there
23-
tags = ["manual"],
24-
)
2517

2618
filegroup(
2719
name = "distribution",

‎tools/publish/BUILD.bazel

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
load("//python:pip.bzl", "compile_pip_requirements")
2+
3+
compile_pip_requirements(
4+
name = "requirements",
5+
requirements_windows = "requirements_windows.txt",
6+
# This fails on RBE and MacOS right now, and we don't need coverage there
7+
tags = ["manual"],
8+
)

‎tools/publish/README.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
# Publish to pypi with twine
2+
3+
https://twine.readthedocs.io/en/stable/

‎python/runfiles/requirements.in renamed to ‎tools/publish/requirements.in

File renamed without changes.

‎python/runfiles/requirements.txt renamed to ‎tools/publish/requirements.txt

File renamed without changes.

‎python/runfiles/requirements_windows.txt renamed to ‎tools/publish/requirements_windows.txt

File renamed without changes.

0 commit comments

Comments
 (0)
0