check for optional params

Marc Sherry · Marc Sherry · commit c6a0f3cb1abf · 2012-06-17T09:49:36.000-07:00
diff --git a/balanced/__init__.py b/balanced/__init__.py
@@ -1,4 +1,4 @@
-__version__ = '0.8.8'
+__version__ = '0.8.9'
 from collections import defaultdict
 import contextlib
 
diff --git a/balanced/resources.py b/balanced/resources.py
@@ -480,12 +480,13 @@ def debit(self, amount=None, appears_on_statement_as=None,
             source_uri=source_uri,
         ).save()
 
-    def hold(self, amount, meta=None, source_uri=None):
+    def hold(self, amount, description=None, meta=None, source_uri=None):
         meta = meta or {}
         return Hold(
             uri=self.holds_uri,
             amount=amount,
             meta=meta,
+            description=description,
             source_uri=source_uri,
             ).save()
 
@@ -561,30 +562,30 @@ def create_card(self,
             country_code=None,
             phone_number=None,
             ):
-            return Card(
-                card_number=card_number,
-                expiration_month=expiration_month,
-                expiration_year=expiration_year,
-                name=name,
-                security_code=security_code,
-                street_address=street_address,
-                postal_code=postal_code,
-                city=city,
-                region=region,
-                country_code=country_code,
-                phone_number=phone_number,
-                ).save()
+        return Card(
+            card_number=card_number,
+            expiration_month=expiration_month,
+            expiration_year=expiration_year,
+            name=name,
+            security_code=security_code,
+            street_address=street_address,
+            postal_code=postal_code,
+            city=city,
+            region=region,
+            country_code=country_code,
+            phone_number=phone_number,
+            ).save()
 
     def create_bank_account(self,
             name,
             account_number,
             bank_code,
             ):
-            return BankAccount(
-                name=name,
-                account_number=account_number,
-                bank_code=bank_code,
-                ).save()
+        return BankAccount(
+            name=name,
+            account_number=account_number,
+            bank_code=bank_code,
+            ).save()
 
     def create_buyer(self, email_address, card_uri, name=None, meta=None):
         meta = meta or {}
@@ -625,12 +626,14 @@ def save(self):
 class Debit(Resource):
     __metaclass__ = resource_base(collection='debits')
 
-    def refund(self, amount=None, description=None):
+    def refund(self, amount=None, description=None, meta=None):
+        meta = meta or {}
         return Refund(
             uri=self.refunds_uri,
             debit_uri=self.uri,
             amount=amount,
-            description=description
+            description=description,
+            meta=meta,
         ).save()
 
 
diff --git a/tests/suite.py b/tests/suite.py
@@ -223,10 +223,11 @@ def test_06_debit_buyer_account_and_refund(self):
 
     def test_07_create_hold_and_void_it(self):
         account = self._find_account('buyer')
-        hold = account.hold(amount=1500)
+        hold = account.hold(amount=1500, description='Hold me')
         self.assertEqual(hold.fee, 35)
         self.assertEqual(hold.account.uri, account.uri)
         self.assertFalse(hold.is_void)
+        self.assertEqual(hold.description, 'Hold me')
         hold.void()
         self.assertTrue(hold.is_void)
         self.assertEqual(hold.fee, 35)  # fee still the same

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-__version__ = '0.8.8'`
	`1`	`+__version__ = '0.8.9'`
`2`	`2`	`from collections import defaultdict`
`3`	`3`	`import contextlib`
`4`	`4`