fix "unlock of unowned mutex" error when call "captureFrame()" func on windows (flutter-webrtc#1460)

liliBestCoder · quxiaojun · web-flow · commit 54ae400bea0b · 2023-09-27T15:38:17.000+08:00
* fix "D:\a_work\1\s\src\vctools\crt\github\stl\src\mutex.cpp(164): unlock of unowned mutex" error when call "captureFrame()" func on windows

* change comment

---------

Co-authored-by: quxiaojun &lt;quxiaojun@whalepms.com&gt;
diff --git a/common/cpp/include/flutter_frame_capturer.h b/common/cpp/include/flutter_frame_capturer.h
@@ -27,6 +27,7 @@ class FlutterFrameCapturer
   std::string path_;
   std::mutex mutex_;
   scoped_refptr<RTCVideoFrame> frame_;
+  volatile bool catch_frame_;
 
   bool SaveFrame();
 };
diff --git a/common/cpp/src/flutter_frame_capturer.cc b/common/cpp/src/flutter_frame_capturer.cc
@@ -21,14 +21,21 @@ void FlutterFrameCapturer::OnFrame(scoped_refptr<RTCVideoFrame> frame) {
   }
 
   frame_ = frame.get()->Copy();
-  mutex_.unlock();
+  catch_frame_ = true;
 }
 
 void FlutterFrameCapturer::CaptureFrame(
     std::unique_ptr<MethodResultProxy> result) {
   mutex_.lock();
+  // Here init catch_frame_ flag
+  catch_frame_ = false;
+
   track_->AddRenderer(this);
-  // Here the OnFrame method has to unlock the mutex
+  // Here waiting for catch_frame_ is set to true
+  while(!catch_frame_){}
+  // Here unlock the mutex
+  mutex_.unlock();
+
   mutex_.lock();
   track_->RemoveRenderer(this);
 
