Proving harder than I thought and looks like first few conditionals didn't work

b-cheng · b-cheng · commit b8baa8d25691 · 2019-02-07T09:54:56.000-05:00
diff --git a/sumAll/sumAll.js b/sumAll/sumAll.js
@@ -9,12 +9,12 @@ const sumAll = function(first, last) {
 			finalSum+=i
 		}
 		return finalSum
-	} else if (first > last){
+	} else if (first > last) {
 		//something to figure out how to reverse this
-		var finalSum=0;
+		var fakeFirst = first;
 		first=last;
-		last=first;
-		for (var i=last; i <= first; i++) {
+		last=fakeFirst;
+		for (var i=first; i <= last; i++) {
 			finalSum+=i
 		}
 		return finalSum
diff --git a/sumAll/sumAll.spec.js b/sumAll/sumAll.spec.js
@@ -10,13 +10,13 @@ describe('sumAll', function() {
   it('works with larger number first', function() {
     expect(sumAll(123, 1)).toEqual(7626);
   });
-  xit('returns ERROR with negative numbers', function() {
+  it('returns ERROR with negative numbers', function() {
     expect(sumAll(-10, 4)).toEqual('ERROR');
   });
-  xit('returns ERROR with non-number parameters', function() {
+  it('returns ERROR with non-number parameters', function() {
     expect(sumAll(10, "90")).toEqual('ERROR');
   });
-  xit('returns ERROR with non-number parameters', function() {
+  it('returns ERROR with non-number parameters', function() {
     expect(sumAll(10, [90, 1])).toEqual('ERROR');
   });
 });
