save a reference to created tasks, to avoid tasks disappearing mid-execution (microsoft#2005)

anio · tracyboehrer · web-flow · commit 786650eb1224 · 2024-01-26T08:58:43.000-06:00
Co-authored-by: tracyboehrer &lt;tracyboehrer@users.noreply.github.com&gt;
diff --git a/libraries/botbuilder-integration-aiohttp/botbuilder/integration/aiohttp/streaming/aiohttp_web_socket.py b/libraries/botbuilder-integration-aiohttp/botbuilder/integration/aiohttp/streaming/aiohttp_web_socket.py
@@ -29,7 +29,7 @@ def __init__(
 
     def dispose(self):
         if self._session:
-            asyncio.create_task(self._session.close())
+            task = asyncio.create_task(self._session.close())
 
     async def close(self, close_status: WebSocketCloseStatus, status_description: str):
         await self._aiohttp_ws.close(
diff --git a/libraries/botframework-streaming/botframework/streaming/protocol_adapter.py b/libraries/botframework-streaming/botframework/streaming/protocol_adapter.py
@@ -75,7 +75,7 @@ async def _on_receive_response(self, identifier: UUID, response: ReceiveResponse
 
     def _on_cancel_stream(self, content_stream_assembler: PayloadStreamAssembler):
         # TODO: on original C# code content_stream_assembler is typed as IAssembler
-        asyncio.create_task(
+        task = asyncio.create_task(
             self._send_operations.send_cancel_stream(
                 content_stream_assembler.identifier
             )

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ async def _on_receive_response(self, identifier: UUID, response: ReceiveResponse`
`75`	`75`
`76`	`76`	`def _on_cancel_stream(self, content_stream_assembler: PayloadStreamAssembler):`
`77`	`77`	`# TODO: on original C# code content_stream_assembler is typed as IAssembler`
`78`		`- asyncio.create_task(`
	`78`	`+ task = asyncio.create_task(`
`79`	`79`	`self._send_operations.send_cancel_stream(`
`80`	`80`	`content_stream_assembler.identifier`
`81`	`81`	`)`