fix(parser): fix data types for sourceIPAddress and sequencer fields in S3RecordModel Model
#6154
Conversation
…dress and not to have sequencer
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
|
sourceIPAddress and sequencer fields in S3RecordSchema Model
sourceIPAddress and sequencer fields in S3RecordSchema ModelsourceIPAddress and sequencer fields in S3RecordModel Model
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6154 +/- ##
========================================
Coverage 96.19% 96.19%
========================================
Files 235 235
Lines 11229 11229
Branches 828 828
========================================
Hits 10802 10802
Misses 337 337
Partials 90 90 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Thanks for the super fast PR @DKurilo! APPROVED!
We will release a new version with this fix tomorrow.
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Issue number: #6150
Summary
make it possible for S3 object to have s3.amazonaws.com in sourceIPAddress and not to have sequencer
Changes
sourceIPAddress can be IP address or s3.amazonaws.com
sequencer is optional
User experience
Library failed during S3 LifecycleTransition parsin
Now it works.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.