fix(parser): change ApproximateCreationDateTime field to datetime in DynamoDBStreamChangedRecordModel #3049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #3048
Summary
This promotes
ApproximateCreationDateTimeto adatetimeobject (instead ofdate) so that pydantic v2 will correctly deserialize it when parsing DynamoDB stream events.Changes
Only the type of
ApproximateCreationDateTimehas changed.User experience
If users would like to rely on a proper
dateobject after the change, they need to usedatetime'sdatemethod. Here's how that may look like.Before the change
After the change
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
Yes, this could break existing code using Pydantic V1 that examines `ApproximateCreationDateTime` and relies on it being a proper date object.RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.