10BC0 fix(ci): install poetry before calling setup/python with cache by rubenfonseca · Pull Request #1315 · aws-powertools/powertools-lambda-python · GitHub
[go: up one dir, main page]
Skip to content

fix(ci): install poetry before calling setup/python with cache #1315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
heitorlessa merged 1 commit into from
Jul 19, 2022
Merged

fix(ci): install poetry before calling setup/python with cache #1315

heitorlessa merged 1 commit into from
Jul 19, 2022

Conversation

@rubenfonseca
Copy link
Contributor
@rubenfonseca rubenfonseca commented Jul 19, 2022 •
edited
Loading

Issue number: #1009

Summary

Changes

Please provide a summary of what's being changed

This fixes a problem when Github actions that used poetry and dependency caching would fail, because poetry was not installed. Following the official documentation recomendation, we install poetry manually before the actions/setup-python action.

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 19, 2022
@boring-cyborg boring-cyborg bot added the github-actions Pull requests that update Github_actions code label Jul 19, 2022
@rubenfonseca rubenfonseca requested a review from heitorlessa July 19, 2022 10:03
@github-actions github-actions bot added the bug Something isn't working label Jul 19, 2022
@heitorlessa heitorlessa changed the title fix(ci): install poetry before calling setup/python fix(ci): install poetry before calling setup/python with cache Jul 19, 2022
@heitorlessa heitorlessa merged commit 22a9078 into aws-powertools:develop Jul 19, 2022
@rubenfonseca rubenfonseca deleted the fix/install-poetry branch July 19, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@heitorlessa heitorlessa heitorlessa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working github-actions Pull requests that update Github_actions code size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rubenfonseca @heitorlessa
0