fix(logger): support additional args for handlers when injecting lambda context #1276
Conversation
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
|
No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure. |
|
hey @RonRademaker thanks a lot for this it's a no brainer to add in this week's release (EOW). Could you create bug issue so we can backtrack it in the future? |
Added a report here #1277 |
|
Thanks a lot @RonRademaker - we'll make a release later today and notify you once it's available by EOD |
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Issue number: #1277
Summary
Changes
Preserve
argsandkwargsin thelogger.inject_lambda_contextdecoratorUser experience
After @heitorlessa 's talk at our meetup last Thursday I tried to add the logger to our project. The lambda handler was already decorated with a couple of decorators, one of which injects additional parameters into the handler. The decorator did not support this, simply passing on args and kwargs fixes this issue and allows the decorator to be used on lambda handlers that support additional arguments.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.