8000 Comparing aws-cdk@v2.1004.0...aws-cdk@v2.1005.0 · aws/aws-cdk-cli · GitHub
[go: up one dir, main page]
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: aws/aws-cdk-cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: aws-cdk@v2.1004.0
Choose a base ref
...
head repository: aws/aws-cdk-cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: aws-cdk@v2.1005.0
Choose a head ref
  • 14 commits
  • 264 files changed
  • 5 contributors

Commits on Mar 13, 2025

  1. chore(cli): fix tests are grouped incorrectly (#228) 

    This just annoyed me a lot. Let's fix it!
No other changes than moving tests around.

---
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license
    @mrgrain
    mrgrain authored Mar 13, 2025
    Configuration menu
    Copy the full SHA
    59d44ee View commit details
    Browse the repository at this point in the history

  2. chore(deps-dev): bump axios from 1.8.1 to 1.8.2 (#213) 

    Bumps [axios](https://github.com/axios/axios) from 1.8.1 to 1.8.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/axios/axios/releases">axios's
releases</a>.</em></p>
<blockquote>
<h2>Release v1.8.2</h2>
<h2>Release notes:</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>http-adapter:</strong> add allowAbsoluteUrls to path
building (<a
href="https://redirect.github.com/axios/axios/issues/6810">#6810</a>)
(<a
href="https://github.com/axios/axios/commit/fb8eec214ce7744b5ca787f2c3b8339b2f54b00f">fb8eec2</a>)</li>
</ul>
<h3>Contributors to this release</h3>
<ul>
<li><!-- raw HTML omitted --> <a href="https://github.com/lexcorp16"
title="+1/-1 ([#6810](axios/axios#6810)
)">Fasoro-Joseph Alexander</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/axios/axios/blob/v1.x/CHANGELOG.md">axios's
changelog</a>.</em></p>
<blockquote>
<h2><a
href="https://github.com/axios/axios/compare/v1.8.1...v1.8.2">1.8.2</a>
(2025-03-07)</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>http-adapter:</strong> add allowAbsoluteUrls to path
building (<a
href="https://redirect.github.com/axios/axios/issues/6810">#6810</a>)
(<a
href="https://github.com/axios/axios/commit/fb8eec214ce7744b5ca787f2c3b8339b2f54b00f">fb8eec2</a>)</li>
</ul>
<h3>Contributors to this release</h3>
<ul>
<li><!-- raw HTML omitted --> <a href="https://github.com/lexcorp16"
title="+1/-1 ([#6810](axios/axios#6810)
)">Fasoro-Joseph Alexander</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/axios/axios/commit/a9f7689b0c4b6d68c7f587c3aa376860da509d94"><code>a9f7689</code></a>
chore(release): v1.8.2 (<a
href="https://redirect.github.com/axios/axios/issues/6812">#6812</a>)</li>
<li><a
href="https://github.com/axios/axios/commit/fb8eec214ce7744b5ca787f2c3b8339b2f54b00f"><code>fb8eec2</code></a>
fix(http-adapter): add allowAbsoluteUrls to path building (<a
href="https://redirect.github.com/axios/axios/issues/6810">#6810</a>)</li>
<li><a
href="https://github.com/axios/axios/commit/98120457559e573024862e2925d56295a965ad7e"><code>9812045</code></a>
chore(sponsor): update sponsor block (<a
href="https://redirect.github.com/axios/axios/issues/6804">#6804</a>)</li>
<li><a
href="https://github.com/axios/axios/commit/72acf759373ef4e211d5299818d19e50e08c02f8"><code>72acf75</code></a>
chore(sponsor): update sponsor block (<a
href="https://redirect.github.com/axios/axios/issues/6794">#6794</a>)</li>
<li>See full diff in <a
href="https://github.com/axios/axios/compare/v1.8.1...v1.8.2">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=axios&package-manager=npm_and_yarn&previous-version=1.8.1&new-version=1.8.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the
[Security Alerts
page](https://github.com/aws/aws-cdk-cli/network/alerts).

</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    @dependabot
    dependabot[bot] authored Mar 13, 2025
    Configuration menu
    Copy the full SHA
    f1ef615 View commit details
    Browse the repository at this point in the history

  3. chore: enforce consistent-type-imports everywhere (#229) 

    We were already enforcing this rule in `toolkit-lib`. Let's enforce it
everywhere.

---
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license

---------

Signed-off-by: github-actions <github-actions@github.com>
Co-authored-by: github-actions <github-actions@github.com>
    @mrgrain
    mrgrain and github-actions authored Mar 13, 2025
    Configuration menu
    Copy the full SHA
    008590b View commit details
    Browse the repository at this point in the history

  4. chore(deps): bump @babel/helpers from 7.26.9 to 7.26.10 (#230) 

    Bumps
[@babel/helpers](https://github.com/babel/babel/tree/HEAD/packages/babel-helpers)
from 7.26.9 to 7.26.10.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/babel/babel/releases"><code>@​babel/helpers</code>'s
releases</a>.</em></p>
<blockquote>
<h2>v7.26.10 (2025-03-11)</h2>
<p>Thanks <a
href="https://github.com/jordan-choi"><code>@​jordan-choi</code></a> and
<a
href="https://github.com/mmmsssttt404"><code>@​mmmsssttt404</code></a>
for your first PRs!</p>
<p>This release includes a fix for <a
href="https://github.com/babel/babel/security/advisories/GHSA-968p-4wvh-cqc8">https://github.com/babel/babel/security/advisories/GHSA-968p-4wvh-cqc8</a>,
a security vulnerability which affects the <code>.replace</code> method
of transpiled regular expressions that use named capturing groups.</p>
<h4>:eyeglasses: Spec Compliance</h4>
<ul>
<li><code>babel-parser</code>
<ul>
<li><a
href="https://redirect.github.com/babel/babel/pull/17159">#17159</a>
Disallow decorator in array pattern (<a
href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
</ul>
<h4>:bug: Bug Fix</h4>
<ul>
<li><code>babel-parser</code>, <code>babel-template</code>
<ul>
<li><a
href="https://redirect.github.com/babel/babel/pull/17164">#17164</a>
Fix: always initialize ExportDeclaration attributes (<a
href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
<li><code>babel-core</code>
<ul>
<li><a
href="https://redirect.github.com/babel/babel/pull/17142">#17142</a>
fix: &quot;Map maximum size exceeded&quot; in deepClone (<a
href="https://github.com/liuxingbaoyu"><code>@​liuxingbaoyu</code></a>)</li>
</ul>
</li>
<li><code>babel-parser</code>,
<code>babel-plugin-transform-typescript</code>
<ul>
<li><a
href="https://redirect.github.com/babel/babel/pull/17154">#17154</a>
Update typescript parser tests (<a
href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
<li><code>babel-traverse</code>
<ul>
<li><a
href="https://redirect.github.com/babel/babel/pull/17151">#17151</a>
fix: Should not evaluate vars in child scope (<a
href="https://github.com/liuxingbaoyu"><code>@​liuxingbaoyu</code></a>)</li>
</ul>
</li>
<li><code>babel-generator</code>
<ul>
<li><a
href="https://redirect.github.com/babel/babel/pull/17153">#17153</a>
fix: Correctly generate <code>abstract override</code> (<a
href="https://github.com/liuxingbaoyu"><code>@​liuxingbaoyu</code></a>)</li>
</ul>
</li>
<li><code>babel-parser</code>
<ul>
<li><a
href="https://redirect.github.com/babel/babel/pull/17107">#17107</a> Fix
source type detection when parsing TypeScript (<a
href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
<li><code>babel-helpers</code>, <code>babel-runtime</code>,
<code>babel-runtime-corejs2</code>, <code>babel-runtime-corejs3</code>
<ul>
<li><a
href="https://redirect.github.com/babel/babel/pull/17173">#17173</a> Fix
processing of replacement pattern with named capture groups (<a
href="https://github.com/%5Bmmmsssttt404%5D(https://github.com/mmmsssttt404)"><code>@​mmmsssttt404</code></a>)</li>
</ul>
</li>
</ul>
<h4>:nail_care: Polish</h4>
<ul>
<li><code>babel-standalone</code>
<ul>
<li><a
href="https://redirect.github.com/babel/babel/pull/17158">#17158</a>
Avoid warnings when re-bundling <code>@​babel/standalone</code> with
webpack (<a
href="https://github.com/liuxingbaoyu"><code>@​liuxingbaoyu</code></a>)</li>
</ul>
</li>
</ul>
<h4>:house: Internal</h4>
<ul>
<li><code>babel-parser</code>
<ul>
<li><a
href="https://redirect.github.com/babel/babel/pull/17160">#17160</a>
Left-value parsing cleanup (<a
href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
</ul>
<h4>Committers: 6</h4>
<ul>
<li>Babel Bot (<a
href="https://github.com/babel-bot"><code>@​babel-bot</code></a>)</li>
<li>Huáng Jùnliàng (<a
href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
<li>Nicolò Ribaudo (<a
href="https://github.com/nicolo-ribaudo"><code>@​nicolo-ribaudo</code></a>)</li>
<li>Yunyoung Jordan Choi (<a
href="https://github.com/jordan-choi"><code>@​jordan-choi</code></a>)</li>
<li><a
href="https://github.com/liuxingbaoyu"><code>@​liuxingbaoyu</code></a></li>
<li><a
href="https://github.com/mmmsssttt404"><code>@​mmmsssttt404</code></a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/babel/babel/blob/main/CHANGELOG.md"><code>@​babel/helpers</code>'s
changelog</a>.</em></p>
<blockquote>
<h2>v7.26.10 (2025-03-11)</h2>
<h4>:eyeglasses: Spec Compliance</h4>
<ul>
<li><code>babel-parser</code>
<ul>
<li><a
href="https://redirect.github.com/babel/babel/pull/17159">#17159</a>
Disallow decorator in array pattern (<a
href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
</ul>
<h4>:bug: Bug Fix</h4>
<ul>
<li><code>babel-parser</code>, <code>babel-template</code>
<ul>
<li><a
href="https://redirect.github.com/babel/babel/pull/17164">#17164</a>
Fix: always initialize ExportDeclaration attributes (<a
href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
<li><code>babel-core</code>
<ul>
<li><a
href="https://redirect.github.com/babel/babel/pull/17142">#17142</a>
fix: &quot;Map maximum size exceeded&quot; in deepClone (<a
href="https://github.com/liuxingbaoyu"><code>@​liuxingbaoyu</code></a>)</li>
</ul>
</li>
<li><code>babel-parser</code>,
<code>babel-plugin-transform-typescript</code>
<ul>
<li><a
href="https://redirect.github.com/babel/babel/pull/17154">#17154</a>
Update typescript parser tests (<a
href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
<li><code>babel-traverse</code>
<ul>
<li><a
href="https://redirect.github.com/babel/babel/pull/17151">#17151</a>
fix: Should not evaluate vars in child scope (<a
href="https://github.com/liuxingbaoyu"><code>@​liuxingbaoyu</code></a>)</li>
</ul>
</li>
<li><code>babel-generator</code>
<ul>
<li><a
href="https://redirect.github.com/babel/babel/pull/17153">#17153</a>
fix: Correctly generate <code>abstract override</code> (<a
href="https://github.com/liuxingbaoyu"><code>@​liuxingbaoyu</code></a>)</li>
</ul>
</li>
<li><code>babel-parser</code>
<ul>
<li><a
href="https://redirect.github.com/babel/babel/pull/17107">#17107</a> Fix
source type detection when parsing TypeScript (<a
href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
<li><code>babel-helpers</code>, <code>babel-runtime</code>,
<code>babel-runtime-corejs2</code>, <code>babel-runtime-corejs3</code>
<ul>
<li><a
href="https://redirect.github.com/babel/babel/pull/17173">#17173</a> Fix
processing of replacement pattern with named capture groups (<a
href="https://github.com/%5Bmmmsssttt404%5D(https://github.com/mmmsssttt404)"><code>@​mmmsssttt404</code></a>)</li>
</ul>
</li>
</ul>
<h4>:nail_care: Polish</h4>
<ul>
<li><code>babel-standalone</code>
<ul>
<li><a
href="https://redirect.github.com/babel/babel/pull/17158">#17158</a>
Avoid warnings when re-bundling <code>@​babel/standalone</code> with
webpack (<a
href="https://github.com/liuxingbaoyu"><code>@​liuxingbaoyu</code></a>)</li>
</ul>
</li>
</ul>
<h4>:house: Internal</h4>
<ul>
<li><code>babel-parser</code>
<ul>
<li><a
href="https://redirect.github.com/babel/babel/pull/17160">#17160</a>
Left-value parsing cleanup (<a
href="https://github.com/JLHwung"><code>@​JLHwung</code></a>)</li>
</ul>
</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/babel/babel/commit/e1ce99df422971175249509e7bbc2b327b8f7957"><code>e1ce99d</code></a>
v7.26.10</li>
<li><a
href="https://github.com/babel/babel/commit/d5952e80c0faa5ec20e35085531b6e572d31dad4"><code>d5952e8</code></a>
Fix processing of replacement pattern with named capture groups (<a
href="https://github.com/babel/babel/tree/HEAD/packages/babel-helpers/issues/17173">#17173</a>)</li>
<li>See full diff in <a
href="https://github.com/babel/babel/commits/v7.26.10/packages/babel-helpers">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@babel/helpers&package-manager=npm_and_yarn&previous-version=7.26.9&new-version=7.26.10)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the
[Security Alerts
page](https://github.com/aws/aws-cdk-cli/network/alerts).

</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    @dependabot
    dependabot[bot] authored Mar 13, 2025
    Configuration menu
    Copy the full SHA
    3791941 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2025

  1. fix(cli): cannot set progress via app or user configuration (#231) 

    In [v2.172.0](https://github.com/aws/aws-cdk/releases/tag/v2.172.0) (via
aws/aws-cdk@069b72c)
we accidentally broke the "bar" stack activity progress output mode (*).
Turns out no-one noticed.

In
[v2.1002.0](https://github.com/aws/aws-cdk-cli/releases/tag/aws-cdk%40v2.1002.0)
(via
0d9912f)
this got unintentionally fixed and the `--progress` was honored again.
However the accidental fix didn't consider options set by app or user
configuration. Again noone really noticed, until this week a user
alerted my to the issue on the cdk.dev Slack.

This PR fixes `progress` set via app or user configuration.

(*) This line is the culprit:

aws/aws-cdk@069b72c#diff-d03bd87f399ba5824d5442aa691df8b6f08f4f8a3848cfc8492c3d52fab5e48bR105
Previously "default" verbosity was a `0`, which meant `verbose = 0` and
later on `!verbose` would turn into `true`.
The change caused `verbose` to be a value different than `0` and thus
turning `!verbose` to be `false` and the code would always assume we are
in verbose logging mode and must use the "events" progress.

---
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license
    @mrgrain
    mrgrain authored Mar 14, 2025
    Configuration menu
    Copy the full SHA
    5631014 View commit details
    Browse the repository at this point in the history

  2. chore(toolkit-lib): fix s3 docs upload (#232) 

    Re-write the script to upload the `toolkit-lib` docs S3. This has been
AI assisted and actually been tested in a testing repo.

---
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license
    @mrgrain
    mrgrain authored Mar 14, 2025
    Configuration menu
    Copy the full SHA
    dba601a View commit details
    Browse the repository at this point in the history

  3. fix(cli): fix for code scanning alerts: Prototype-polluting assignment ( 

    #233)

Fix for
[https://github.com/aws/aws-cdk-cli/security/code-scanning/5](https://github.com/aws/aws-cdk-cli/security/code-scanning/5)
[https://github.com/aws/aws-cdk-cli/security/code-scanning/6](https://github.com/aws/aws-cdk-cli/security/code-scanning/6)
[https://github.com/aws/aws-cdk-cli/security/code-scanning/7](https://github.com/aws/aws-cdk-cli/security/code-scanning/7)

To fix the prototype pollution vulnerability, we need to ensure that the
keys used in the `deepSet` function do not include any properties that
can modify `Object.prototype`. This can be achieved by validating the
keys in the `path` array and rejecting any keys that are `__proto__`,
`constructor`, or `prototype`.

The best way to fix this problem without changing existing functionality
is to add a validation step before using the keys in the `path` array.
We will add a check to ensure that none of the keys in the `path` array
are `__proto__`, `constructor`, or `prototype`.

---
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license

---------

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
    @mrgrain @github-advanced-security
    mrgrain and github-advanced-security[bot] authored Mar 14, 2025
    Configuration menu
    Copy the full SHA
    f855b15 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2025

  1. docs: compatibility table for CLI/library versions (#239) 

    Describe the compatibility model, and add a table linking the CLI and
library versions.

---
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license
    @rix0rrr
    rix0rrr authored Mar 17, 2025
    Configuration menu
    Copy the full SHA
    a1fbefe View commit details
    Browse the repository at this point in the history

  2. chore: remove unused packages (#240) 

    We moved `cdk-build-tools` and `yarn-cling` over from the old repo, but
they are not really used here.

Just `bockfs` was being used as a testing tool -- move that into the
`aws-cdk` package using it as a test helper.

---
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license
    @rix0rrr
    rix0rrr authored Mar 17, 2025
    Configuration menu
    Copy the full SHA
    cb8a7e0 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2025

  1. refactor(toolkit): resource metadata (#243) 

    Pulls out resource-metadata extraction into a separate API so it can
easily be reused in other places.
Also adds support for resource metadata to
`EvaluateCloudFormationTemplate` (internal API) in preparation for a
change in hotswap.

---
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license
    @mrgrain
    mrgrain authored Mar 18, 2025
    Configuration menu
    Copy the full SHA
    a139c52 View commit details
    Browse the repository at this point in the history

  2. fix(cli): hotswap is reporting and running changes that don't happen (#… 

    …244)

This change is three fold:

- We clean up the private `HotswapOperation` interface (née
`HotswappableChange`) by removing two unused fields and adding in a new
filed in preparation for structured data alongside hotswap messages
- In the hotswap providers, pull gates outside of the apply function.
This prevents hotswaps being reported when nothing would actually be
done. These are local checks and now just run a little bit earlier.
- In `lambda-functions.ts` don't report hotswappable changes for
versions and aliases. These used to be reported with an empty array for
`resourceNames` and a noop `apply` function. This means that literally
nothing hap
8000
pens with these entries, since `apply` doesn't do anything
and the CLI uses `resourceNames` to print anything. Just removing these
as they are reported as part of a change to the function.

---
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license
    @mrgrain
    mrgrain authored Mar 18, 2025
    Configuration menu
    Copy the full SHA
    53ea256 View commit details
    Browse the repository at this point in the history

  3. fix(toolkit-lib): deployment total time includes stray output (#238) 

    Fixes an extra `Deployment <number>` at the end of the "Total Time"
message reporting the total deployment time.

Adds missing test cases for the `MessageSpan` feature (GenAI supported).

---
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license
    @mrgrain
    mrgrain authored Mar 18, 2025
    Configuration menu
    Copy the full SHA
    ec93ebd View commit details
    Browse the repository at this point in the history

  4. feat(toolkit-lib): report hotswap messages into a message span (#247) 

    Requested by early `toolkit-lib` users, all hotswap messages are now
reported into span. Structured data reported for start and end is
intentionally limited and will be extended further in future.

---
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license

---------

Signed-off-by: github-actions <github-actions@github.com>
Co-authored-by: github-actions <github-actions@github.com>
    @mrgrain
    mrgrain and github-actions authored Mar 18, 2025
    Configuration menu
    Copy the full SHA
    fe143da View commit details
    Browse the repository at this point in the history

  5. fix(cli): write notices to stderr or don't write them at all (#221) 

    (Replaces #188).

On CI systems, the CDK CLI tries to avoid writing to `stderr` because
there are a couple of CI systems that are commonly configured to fail if
any output is written to `stderr`. That means all output, like notices,
must go to `stdout`.

Some commands (like `cdk synth` or `cdk bootstrap --show-template`)
produce usable output on `stdout`, and these are commonly scripted, like
piping their output to a file.

However, because notices must go to `stdout`, these now interfere with
the output of these commands.

This needs a more thorough reworking of the CLI output streams, but
there is a risk of affecting users who are currently relying on the fact
that all output goes to `stdout`.

In this PR, we are doing the first steps to solving this situation:

- Notices will always go to `stderr`, so that they will never interfere
with `stdout` anymore.
- We try to detect what CI system we are running on, and we will
completely suppress notices *unless* we determine that we are running on
a CI system where it is "safe" to write to `sterr` (fail closed).

"Safe" in this case means that the CI system doesn't come with an easy
to toggle checkbox that makes commands fail based on what they print,
instead of their exit codes. The only systems I'm aware of that have
this checkbox are "Azure DevOps", and "TeamCity running PowerShell
scripts".

Even though we know the systems that are "unsafe", we will only show
notices on systems known to be "safe".

Fixes aws/aws-cdk#33589.

Also in this PR, because this grew.

* Introduce `IoDefaultMessages` in the CLI package, which helps migrate
"legacy" logging code to just emit default warning/info/etc messages to
the IoHost.
* Removed the ability to log with a `{ message: 'asdf' }` object to the
global logger functions. This wasn't being used anywhere other than
tests, and it's sort of pointless: if you know the code you should be
using the `MessageMaker` to make a message object; if you don't know the
code you can emit a string. There is no need to look up the right code
given a level and a message object.
* Make it possible for result types to be any type, not just object
types. This is necessary to cover the "result" from legacy logging,
where the result is just a string.
* Updated many tests in a test file (`cli-io-host.test.ts`) that failed
type checking, but succeeded running, and therefore didn't fail the
build of #220.
* Centralized `TestIoHost` into the helper package, and renamed it to
`MockIoHost`.
* Introducing a `FakeIoHost` in the CLI package to assert on messages
emitted to an `IoHost`.

---
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license

---------

Signed-off-by: github-actions <github-actions@github.com>
Co-authored-by: github-actions <github-actions@github.com>
    @rix0rrr
    rix0rrr and github-actions authored Mar 18, 2025
    Configuration menu
    Copy the full SHA
    be378de View commit details
    Browse the repository at this point in the history
Loading
0