8000 Comparing v2.170.0...v2.171.0 · aws/aws-cdk · GitHub
[go: up one dir, main page]
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: aws/aws-cdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.170.0
Choose a base ref
...
head repository: aws/aws-cdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.171.0
Choose a head ref
  • 10 commits
  • 36 files changed
  • 5 contributors

Commits on Nov 22, 2024

  1. feat(rds): enhanced monitoring configuration at the cluster level (#3… 

    …2157)

### Issue # (if applicable)

None

### Reason for this change

AWS RDS now supports the configuration of advanced monitoring at the cluster level.

<https://aws.amazon.com/about-aws/whats-new/2024/09/amazon-rds-performance-insights-supports-aurora-cluster-level-configuration/?nc1=h_ls>

This feature is essential for creating limitless database cluster. (#32151)

### Description of changes

I added `enableClusterLevelEnhancedMonitoring` prop to `ClusterProps`.
If this prop enabled, `mon
8000
itoringInterval` and `monitoringRole` is applied to not the instances but the cluster.

Enhanced monitoring configuration for the cluster and instances has some restrictions.
- When setting the `monitoringRoleArn` for both the cluster and instances, the values must be identical.
- When setting the `monitoringInterval` for both the cluster and instances, the values must be identical.
- When the `monitoringInterval` or `monitoringRoleArn` is set at the cluster level, enhanced monitoring will be enabled even if the same values are not specified for the instances.

Based on the above, I decided to add a flag (`enableClusterLevelEnhancedMonitoring`) to switch the application of `monitoringInterval` and `monitoringRole` between the instance level and the cluster level to avoid breaking changes to the existing props.


#### Verification Results Memo

The value of the Enhanced Monitoring configuration must be the same for both the cluster level and the instance level.

```ts
  "DatabaseB269D8BB": {
   "Type": "AWS::RDS::DBCluster",
   "Properties": {
    ...,
    "Engine": "aurora-postgresql",
    "EngineVersion": "16.1",
    "MonitoringInterval": 5,
    "MonitoringRoleArn": {
     "Fn::GetAtt": [
      "DatabaseMonitoringRoleForCluster91F5067E",
      "Arn"
     ]
    },
  },
  "DatabasewriterInstanceEBFCC003": {
   "Type": "AWS::RDS::DBInstance",
   "Properties": {
    ...,
    "DBClusterIdentifier": {
     "Ref": "DatabaseB269D8BB"
    },
    "Engine": "aurora-postgresql",
    "MonitoringInterval": 1,
    "MonitoringRoleArn": {
     "Fn::GetAtt": [
      "DatabaseMonitoringRole576991DA",
      "Arn"
     ]
    },
  }
```

```sh
           | Database/writerInstance (DatabasewriterInstanceEBFCC003) Resource handler returned message: "MonitoringInterval conflicts with cluster level parameter. (Service: Rds, Status Code: 400, Request ID: 7c9d9023-fe2a-4b39-a939-22cec3595041)" (RequestToken: bc3e18eb-2daa-4f25-c205-11f1ec70fc15, HandlerErrorCode: InvalidRequest)
```

The monitoring role arn must be the same for both cluster and instance level.

```yaml
 "DatabaseB269D8BB": {
   "Type": "AWS::RDS::DBCluster",
   "Properties": {
    ...,
    "Engine": "aurora-postgresql",
    "EngineVersion": "16.1",
    "MonitoringInterval": 5,
    "MonitoringRoleArn": {
     "Fn::GetAtt": [
      "DatabaseMonitoringRoleForCluster91F5067E",
      "Arn"
     ]
    },
  },
  "DatabasewriterInstanceEBFCC003": {
   "Type": "AWS::RDS::DBInstance",
   "Properties": {
    ...,
    "DBClusterIdentifier": {
     "Ref": "DatabaseB269D8BB"
    },
    "Engine": "aurora-postgresql",
    "MonitoringInterval": 5,
    "MonitoringRoleArn": {
     "Fn::GetAtt": [
      "DatabaseMonitoringRole576991DA",
      "Arn"
     ]
    },
  }
```

```sh
Resource handler returned message: "MonitoringRoleArn conflicts with cluster level parameter. (Service: Rds, Status Code: 400, Request ID: 761a867d-409e-4208-a08e-5591607d0ed0)" (RequestToken: fb691324-f37c-405d-e5bd-447911f7664f, HandlerErrorCode: InvalidRequest)
```

### Description of how you validated changes

Add both unit and integ tests

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    @badmintoncryer
    badmintoncryer authored Nov 22, 2024
    Configuration menu
    Copy the full SHA
    01f2dcd View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into merge-back/2.170.0

    @mergify
    mergify[bot] authored Nov 22, 2024
    Configuration menu
    Copy the full SHA
    cd7c71d View commit details
    Browse the repository at this point in the history

  3. chore(rds): add postgres engine 17.2, 16.6, 15.10, 14.15, 13.18, and … 

    …12.22 (#32249)

### Issue # (if applicable)

None

### Reason for this change

AWS RDS now supports for new postgresql minor version 17.2, 16.6, 15.10,
14.15, 13.18, and 12.22.

https://aws.amazon.com/about-aws/whats-new/2024/11/amazon-rds-postgresql-supports-minor-versions/

### Description of changes

Add these minor versions to both instance and cluster engines.
And I also added some minor versions are not defined in the cluster
engines.
 - 17.1, 16.5, 15.9, 14.14, 13.17, 12.21

### Description of how you validated changes

None

### Checklist
- [x] My code adheres to the [CONTRIBUTING
GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and
[DESIGN
GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license*
    @badmintoncryer
    badmintoncryer authored Nov 22, 2024
    Configuration menu
    Copy the full SHA
    f19cc66 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into merge-back/2.170.0

    @mergify
    mergify[bot] authored Nov 22, 2024
    Configuration menu
    Copy the full SHA
    1700700 View commit details
    Browse the repository at this point in the history

  5. chore(merge-back): 2.170.0 (#32246) 

    See [CHANGELOG](https://github.com/aws/aws-cdk/blob/merge-back/2.170.0/CHANGELOG.md)
    @mergify
    mergify[bot] authored Nov 22, 2024
    Configuration menu
    Copy the full SHA
    74086a0 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2024

  1. feat(rds): support zero ACU for Aurora Serverless V2 (#32231) 

    ### Issue # (if applicable)

Closes #32234.

### Reason for this change
Amazon Aurora Serverless v2 supports scaling to zero capacity.

Ref: https://aws.amazon.com/about-aws/whats-new/2024/11/amazon-aurora-serverless-v2-scaling-zero-capacity/



### Description of changes
"Updated validation to permit zero as a value for `serverlessV2MinCapacity`.



### Description of how you validated changes
Fix unit tests and add an integ test.



### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    @mazyu36
    mazyu36 authored Nov 23, 2024
    Configuration menu
    Copy the full SHA
    d1b07d9 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. chore(cli-integ): new test case for proxied requests (#32254) 

    This important scenario was missing from the integ test suite.

----

*By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license*
    @otaviomacedo
    otaviomacedo authored Nov 25, 2024
    Configuration menu
    Copy the full SHA
    36c12c9 View commit details
    Browse the repository at this point in the history

  2. fix(cli): sso with proxy fails (#32261) 

    Updating to the latest SDK version to pull in aws/aws-sdk-js-v3#6688

Followup to #32208


### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    @otaviomacedo
    otaviomacedo authored Nov 25, 2024
    Configuration menu
    Copy the full SHA
    bedcf16 View commit details
    Browse the repository at this point in the history

  3. chore(release): 2.171.0

    AWS CDK Team committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    06a17ee View commit details
    Browse the repository at this point in the history

  4. chore(release): 2.171.0 (#32271) 

    See [CHANGELOG](https://github.com/aws/aws-cdk/blob/bump/2.171.0/CHANGELOG.md)
    @mergify
    mergify[bot] authored Nov 25, 2024
    Configuration menu
    Copy the full SHA
    4957967 View commit details
    Browse the repository at this point in the history
Loading
0