Fix and disable StrongNameSigning

vmuriart · vmuriart · commit 56aee3503700 · 2017-02-05T22:52:17.000-07:00
It works better if they key is in the right folder and its being referenced when signing.
It breaks InternalsVisibleTo though, disabling till have time to look into it. (not that it was actually enabled)
diff --git a/setup.py b/setup.py
@@ -104,12 +104,12 @@ def _get_interop_filename():
 
 def _get_source_files():
     """Walk project and collect the files needed for ext_module"""
-    for ext in (".sln", ".snk", ".config"):
+    for ext in (".sln", ".config"):
         for path in glob.glob("*" + ext):
             yield path
 
     for root, dirnames, filenames in os.walk("src"):
-        for ext in (".cs", ".csproj", ".sln", ".snk", ".config", ".il",
+        for ext in (".cs", ".csproj", ".snk", ".config", ".il",
                     ".py", ".c", ".h", ".ico"):
             for filename in fnmatch.filter(filenames, "*" + ext):
                 yield os.path.join(root, filename)
diff --git a/src/pythonnet.snk b/src/pythonnet.snk
diff --git a/src/runtime/Python.Runtime.csproj b/src/runtime/Python.Runtime.csproj
@@ -16,7 +16,8 @@
     <PythonBuildDir Condition=" '$(PythonBuildDir)' == '' ">$(SolutionDir)</PythonBuildDir>
     <!--If need to freeze language version: <LangVersion>5</LangVersion> !-->
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
-    <SignAssembly>true</SignAssembly>
+    <SignAssembly>false</SignAssembly>
+    <AssemblyOriginatorKeyFile>..\pythonnet.snk</AssemblyOriginatorKeyFile>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Platform)' == 'x86'">
     <PlatformTarget>x86</PlatformTarget>
diff --git a/src/testing/Python.Test.csproj b/src/testing/Python.Test.csproj
@@ -15,7 +15,8 @@
     <SolutionDir Condition="$(SolutionDir) == '' Or $(SolutionDir) == '*Undefined*'">..\..\</SolutionDir>
     <PythonBuildDir Condition=" '$(PythonBuildDir)' == '' ">$(SolutionDir)</PythonBuildDir>
     <!--If need to freeze language version: <LangVersion>5</LangVersion> !-->
-    <SignAssembly>true</SignAssembly>
+    <SignAssembly>false</SignAssembly>
+    <AssemblyOriginatorKeyFile>..\pythonnet.snk</AssemblyOriginatorKeyFile>
     <ErrorReport>prompt</ErrorReport>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Platform)' == 'x86'">
