Merge pull request tableau#743 from tableau/improve-debug-log2

bcantoni · web-flow · commit 8e1eef5cafea · 2020-12-03T13:09:46.000-08:00
Improve debug logging by including put/post request contents (limited to first 1000 chars)
diff --git a/tableauserverclient/server/endpoint/endpoint.py b/tableauserverclient/server/endpoint/endpoint.py
@@ -50,19 +50,22 @@ def _make_request(self, method, url, content=None, request_object=None,
         if content is not None:
             parameters['data'] = content
 
+        logger.debug(u'request {}, url: {}'.format(method.__name__, url))
+        if content:
+            logger.debug(u'request content: {}'.format(content[:1000]))
+
         server_response = method(url, **parameters)
         self.parent_srv._namespace.detect(server_response.content)
         self._check_status(server_response)
 
         # This check is to determine if the response is a text response (xml or otherwise)
         # so that we do not attempt to log bytes and other binary data.
-        if server_response.encoding:
+        if len(server_response.content) > 0 and server_response.encoding:
             logger.debug(u'Server response from {0}:\n\t{1}'.format(
                 url, server_response.content.decode(server_response.encoding)))
         return server_response
 
     def _check_status(self, server_response):
-        logger.debug(self._safe_to_log(server_response))
         if server_response.status_code >= 500:
             raise InternalServerError(server_response)
         elif server_response.status_code not in Success_codes:
