[rush] Fix empty error logs (microsoft#4997)

dmichon-msft · web-flow · commit d83665cde2c5 · 2024-11-08T02:18:25.000Z
Co-authored-by: David Michon &lt;dmichon-msft@users.noreply.github.com&gt;
diff --git a/common/changes/@microsoft/rush/fix-empty-error-logs_2024-11-08-01-18.json b/common/changes/@microsoft/rush/fix-empty-error-logs_2024-11-08-01-18.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@microsoft/rush",
+      "comment": "Fix an issue where empty error logs were created for operations that did not write to standard error.",
+      "type": "none"
+    }
+  ],
+  "packageName": "@microsoft/rush"
+}
diff --git a/libraries/rush-lib/src/logic/operations/ProjectLogWritable.ts b/libraries/rush-lib/src/logic/operations/ProjectLogWritable.ts
@@ -148,7 +148,7 @@ export class SplitLogFileWritable extends TerminalWritable {
     this.errorLogPath = errorLogPath;
 
     this._logWriter = FileWriter.open(logPath);
-    this._errorLogWriter = FileWriter.open(errorLogPath);
+    this._errorLogWriter = undefined;
   }
 
   // Override writeChunk function to throw custom error

Original file line number	Diff line number	Diff line change
`@@ -148,7 +148,7 @@ export class SplitLogFileWritable extends TerminalWritable {`
`148`	`148`	`this.errorLogPath = errorLogPath;`
`149`	`149`
`150`	`150`	`this._logWriter = FileWriter.open(logPath);`
`151`		`- this._errorLogWriter = FileWriter.open(errorLogPath);`
	`151`	`+ this._errorLogWriter = undefined;`
`152`	`152`	`}`
`153`	`153`
`154`	`154`	`// Override writeChunk function to throw custom error`