Mark fields returning Result as semanticNonNull #1638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60bff38 to
061152c
Compare
061152c to
d22fc7e
Compare
d22fc7e to
d9e56c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #1637
Closes #1605
This PR adds support for semantic nullability as an opt-in feature.
A field gets marked as
@semanticNonNullwhen:nullable-resultfeature is enabled#[graphql(semantic_non_null)]ResultBy introducing the feature as an opt-in, it is now a non-breaking, purely additive change. While I'd want to propose a whole rework to the core type system around nullability, that would be a huge breaking one so I went sideways for now. When the semantic nullability proposal gets merged, it'd be better to make this change more fundamentally, instead of doing workarounds like this.