Remove recarray_fromrecords

taldcroft · taldcroft · commit 7468364aef07 · 2019-09-14T14:42:31.000-04:00
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -284,6 +284,8 @@ astropy.table
 - Changed default table configuration setting ``replace_warnings`` from
   ``['slice']`` to ``[]``.  This removes the default warning when replacing
   a table column that is a slice of another column. [#9144]
+- Removed the non-public method ``astropy.table.np_utils.recarray_fromrecords``.
+  [#9165]
 
 astropy.tests
 ^^^^^^^^^^^^^
diff --git a/astropy/table/np_utils.py b/astropy/table/np_utils.py
@@ -171,26 +171,3 @@ def fix_column_name(val):
             raise
 
     return val
-
-
-def recarray_fromrecords(rec_list):
-    """
-    Partial replacement for `~numpy.core.records.fromrecords` which includes
-    a workaround for the bug with unicode arrays described at:
-    https://github.com/astropy/astropy/issues/3052
-
-    This should not serve as a full replacement for the original function;
-    this only does enough to fulfill the needs of the table module.
-    """
-
-    # Note: This is just copying what Numpy does for converting arbitrary rows
-    # to column arrays in the recarray module; it could be there is a better
-    # way
-    nfields = len(rec_list[0])
-    obj = np.array(rec_list, dtype=object)
-    array_list = [np.array(obj[..., i].tolist()) for i in range(nfields)]
-    formats = []
-    for obj in array_list:
-        formats.append(obj.dtype.str)
-    formats = ','.join(formats)
-    return np.rec.fromarrays(array_list, formats=formats)
diff --git a/astropy/table/table.py b/astropy/table/table.py
@@ -26,7 +26,7 @@
 from .column import (BaseColumn, Column, MaskedColumn, _auto_names, FalseArray,
                      col_copy)
 from .row import Row
-from .np_utils import fix_column_name, recarray_fromrecords
+from .np_utils import fix_column_name
 from .info import TableInfo
 from .index import Index, _IndexModeContext, get_index
 from .connect import TableRead, TableWrite
