8000 chore: correct skip backup tests env variable (#753) · asthamohta/python-spanner@b286389 · GitHub
[go: up one dir, main page]

Skip to content

Commit b286389

Browse files
ansh0lasthamohta
authored andcommitted
chore: correct skip backup tests env variable (googleapis#753)
1 parent 51396d7 commit b286389

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

noxfile.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -271,9 +271,9 @@ def system(session, database_dialect):
271271
install_systemtest_dependencies(session, "-c", constraints_path)
272272

273273
# If POSTGRESQL tests and Emulator, skip the tests
274-
if(os.environ.get("SPANNER_EMULATOR_HOST")):
274+
if os.environ.get("SPANNER_EMULATOR_HOST") and database_dialect == "POSTGRESQL":
275275
session.skip("Postgresql is not supported by Emulator yet.")
276-
276+
277277
# Run py.test against the system tests.
278278
if system_test_exists:
279279
session.run(

tests/system/_helpers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
INSTANCE_ID = os.environ.get(INSTANCE_ID_ENVVAR, INSTANCE_ID_DEFAULT)
3232

3333
SKIP_BACKUP_TESTS_ENVVAR = "SKIP_BACKUP_TESTS"
34-
SKIP_BACKUP_TESTS = True # os.getenv(SKIP_BACKUP_TESTS_ENVVAR) == True
34+
SKIP_BACKUP_TESTS = os.getenv(SKIP_BACKUP_TESTS_ENVVAR) is not None
3535

3636
INSTANCE_OPERATION_TIMEOUT_IN_SECONDS = int(
3737
os.getenv("SPANNER_INSTANCE_OPERATION_TIMEOUT_IN_SECONDS", 560)

0 commit comments

Comments
 (0)
0