8000 Revert "Add DfaMatcherBuilder benchmarks (#764)" · aspnet/Routing@f9f80e3 · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Nov 27, 2018. It is now read-only.

Commit f9f80e3

Browse files
JamesNKJamesNK
committed
Revert "Add DfaMatcherBuilder benchmarks (#764)"
This reverts commit ec11d05.
1 parent ec11d05 commit f9f80e3

File tree

8 files changed

+17
-128
lines changed

8 files changed

+17
-128
lines changed

‎benchmarks/Microsoft.AspNetCore.Routing.Performance/Matching/MatcherAzureBenchmark.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,12 @@
33

44
using System.Threading.Tasks;
55
using BenchmarkDotNet.Attributes;
6+
using Microsoft.AspNetCore.Http.Features;
67

78
namespace Microsoft.AspNetCore.Routing.Matching
89
{
910
// Generated from https://github.com/Azure/azure-rest-api-specs
10-
public class MatcherAzureBenchmark : MatcherAzureBenchmarkBase
11+
public partial class MatcherAzureBenchmark : EndpointRoutingBenchmarkBase
1112
{
1213
private const int SampleCount = 100< 8000 /span>;
1314

‎benchmarks/Microsoft.AspNetCore.Routing.Performance/Matching/MatcherAzureBenchmarkBase.generated.cs renamed to ‎benchmarks/Microsoft.AspNetCore.Routing.Performance/Matching/MatcherAzureBenchmark.generated.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@
77
namespace Microsoft.AspNetCore.Routing.Matching
88
{
99
// This code was generated by the Swaggatherer
10-
public abstract partial class MatcherAzureBenchmarkBase : EndpointRoutingBenchmarkBase
10+
public partial class MatcherAzureBenchmark : EndpointRoutingBenchmarkBase
1111
{
12-
private protected const int EndpointCount = 5160;
12+
private const int EndpointCount = 5160;
1313

14-
private protected void SetupEndpoints()
14+
private void SetupEndpoints()
1515
{
1616
Endpoints = new RouteEndpoint[5160];
1717
Endpoints[0] = CreateEndpoint("/account", "GET");
@@ -5176,7 +5176,7 @@ private protected void SetupEndpoints()
51765176
Endpoints[5159] = CreateEndpoint("/{tenantID}/groups/{groupObjectId}/$links/members/{memberObjectId}", "DELETE");
51775177
}
51785178

5179-
private protected void SetupRequests()
5179+
private void SetupRequests()
51805180
{
51815181
Requests = new HttpContext[5160];
51825182
Requests[0] = new DefaultHttpContext();
@@ -25821,7 +25821,7 @@ private protected void SetupRequests()
2582125821
Requests[5159].Request.Path = "/67fb987d/groups/04d01a8c-6135/$links/members/71b75dbe-0076-";
2582225822
}
2582325823

25824-
private protected Matcher SetupMatcher(MatcherBuilder builder)
25824+
private Matcher SetupMatcher(MatcherBuilder builder)
2582525825
{
2582625826
builder.AddEndpoint(Endpoints[0]);
2582725827
builder.AddEndpoint(Endpoints[1]);

‎benchmarks/Microsoft.AspNetCore.Routing.Performance/Matching/MatcherBuilderAzureBenchmark.cs

Lines changed: 0 additions & 31 deletions
This file was deleted.

‎benchmarks/Microsoft.AspNetCore.Routing.Performance/Matching/MatcherBuilderGithubBenchmark.cs

Lines changed: 0 additions & 31 deletions
This file was deleted.

‎benchmarks/Microsoft.AspNetCore.Routing.Performance/Matching/MatcherBuilderMultipleEntryBenchmark.cs

Lines changed: 0 additions & 50 deletions
This file was deleted.

‎benchmarks/Microsoft.AspNetCore.Routing.Performance/Matching/MatcherGithubBenchmark.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ namespace Microsoft.AspNetCore.Routing.Matching
99
{
1010
// Generated from https://github.com/APIs-guru/openapi-directory
1111
// Use https://editor2.swagger.io/ to convert from yaml to json-
12-
public class MatcherGithubBenchmark : MatcherGithubBenchmarkBase
12+
public partial class MatcherGithubBenchmark : EndpointRoutingBenchmarkBase
1313
{
1414
private BarebonesMatcher _baseline;
1515
private Matcher _dfa;

‎benchmarks/Microsoft.AspNetCore.Routing.Performance/Matching/MatcherGithubBenchmarkBase.generated.cs renamed to ‎benchmarks/Microsoft.AspNetCore.Routing.Performance/Matching/MatcherGithubBenchmark.generated.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@
77
namespace Microsoft.AspNetCore.Routing.Matching
88
{
99
// This code was generated by the Swaggatherer
10-
public partial class MatcherGithubBenchmarkBase : EndpointRoutingBenchmarkBase
10+
public partial class MatcherGithubBenchmark : EndpointRoutingBenchmarkBase
1111
{
12-
private protected const int EndpointCount = 243;
12+
private const int EndpointCount = 243;
1313

14-
private protected void SetupEndpoints()
14+
private void SetupEndpoints()
1515
{
1616
Endpoints = new RouteEndpoint[243];
1717
Endpoints[0] = CreateEndpoint("/emojis", "GET");
@@ -259,7 +259,7 @@ private protected void SetupEndpoints()
259259
Endpoints[242] = CreateEndpoint("/repos/{owner}/{repo}/{archive_format}/{path}", "GET");
260260
}
261261

262-
private protected void SetupRequests()
262+
private void SetupRequests()
263263
{
264264
Requests = new HttpContext[243];
265265
Requests[0] = new DefaultHttpContext();
@@ -1236,7 +1236,7 @@ private protected void SetupRequests()
12361236
Requests[242].Request.Path = "/repos/21a74/f36c8/805b0492-b723-/680ad";
12371237
}
12381238

1239-
private protected Matcher SetupMatcher(MatcherBuilder builder)
1239+
private Matcher SetupMatcher(MatcherBuilder builder)
12401240
{
12411241
builder.AddEndpoint(Endpoints[0]);
12421242
builder.AddEndpoint(Endpoints[1]);

‎tools/Swaggatherer/Template.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -74,21 +74,21 @@ namespace Microsoft.AspNetCore.Routing
7474
// This code was generated by the Swaggatherer
7575
public partial class GeneratedBenchmark : EndpointRoutingBenchmarkBase
7676
{{
77-
private protected const int EndpointCount = {3};
77+
private const int EndpointCount = {3};
7878
79-
private protected void SetupEndpoints()
79+
private void SetupEndpoints()
8080
{{
8181
Endpoints = new RouteEndpoint[{3}];
8282
{0}
8383
}}
8484
85-
private protected void SetupRequests()
85+
private void SetupRequests()
8686
{{
8787
Requests = new HttpContext[{3}];
8888
{1}
8989
}}
9090
91-
private protected Matcher SetupMatcher(MatcherBuilder builder)
91+
private Matcher SetupMatcher(MatcherBuilder builder)
9292
{{
9393
{2}
9494
return builder.Build();

0 commit comments

Comments
 (0)
0