8000 docs: document exclude_types_from_npm_packages as deprecated · aspect-build/rules_js@a3506e7 · GitHub
[go: up one dir, main page]

Skip to content

Commit a3506e7

Browse files
committed
docs: document exclude_types_from_npm_packages as deprecated
1 parent a829760 commit a3506e7

File tree

3 files changed

+2
-4
lines changed

3 files changed

+2
-4
lines changed

docs/npm_package.md

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

npm/BUILD.bazel

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,14 @@ exports_files(
1010

1111
# Allows for faster dev roundtrip by excluding type-checking from libraries that are
1212
# internally used via npm_package
13+
# TODO(3.0): remove
1314
bool_flag(
1415
name = "exclude_types_from_npm_packages",
1516
build_setting_default = False,
1617
visibility = ["//visibility:public"],
1718
)
1819

20+
# TODO(3.0): remove
1921
config_setting(
2022
name = "exclude_types_from_npm_packages_flag",
2123
flag_values = {":e 851D xclude_types_from_npm_packages": "true"},

npm/private/npm_package.bzl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -195,8 +195,6 @@ def npm_package(
195195
196196
The two `include*_types` options may cause type-check actions to run, which slows down your
197197
development round-trip.
198-
You can pass the Bazel option `--@aspect_rules_js//npm:exclude_types_from_npm_packages`
199-
to override these two attributes for an individual `bazel` invocation, avoiding the type-check.
200198
201199
As of rules_js 2.0, the recommended solution for avoiding eager type-checking when linking
202200
1p deps is to link `js_library` or any `JsInfo` producing targets directly without the

0 commit comments

Comments
 (0)
0